Skip to content

Third level category menu issue fix #28260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kishorenagalingam
Copy link
Contributor

@kishorenagalingam kishorenagalingam commented May 18, 2020

Description (*)

In menu, third level menu is accessible now when hovering the second level menu

Related Pull Requests

Before
Third-level-before-fix

After
Third-level-after-fix

Fixed Issues (if relevant)

  1. Fixes Frontend 3rd level of submenu not accessible #28198: Frontend 3rd level of submenu not accessible

Manual testing scenarios (*)

  1. Magento 2.4
  2. Theme Luma and Blank
  3. Create Third level category

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 18, 2020

Hi @kishorenagalingam. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered only manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s). <test-build(s)> is a comma-separated list of build names. Allowed build names are Database Compare, Functional Tests CE, Functional Tests EE, Functional Tests B2B, Integration Tests, Magento Health Index, Sample Data Tests CE, Sample Data Tests EE, Sample Data Tests B2B, Static Tests, Unit Tests, WebAPI Tests.

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@kishorenagalingam
Copy link
Contributor Author

@magento give me test instance - deploy test instance based on PR changes

@magento-engcom-team
Copy link
Contributor

Hi @kishorenagalingam. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @kishorenagalingam, here is your new Magento instance.
Admin access: https://pr-28260.instances.magento-community.engineering/admin_e729
Login: 5c26b3ab Password: 5c7bf2b48110
Instance will be terminated in up to 3 hours.

Copy link
Contributor

@mrtuvn mrtuvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add new line before &.parent

@mrtuvn
Copy link
Contributor

mrtuvn commented May 18, 2020

@magento run all tests

@mrtuvn
Copy link
Contributor

mrtuvn commented May 19, 2020

Failed tests not related with changes

@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels May 19, 2020
@kishorenagalingam
Copy link
Contributor Author

@magento re-run all tests

@kishorenagalingam
Copy link
Contributor Author

@magento run all tests

@eduard13 eduard13 self-assigned this Jun 5, 2020
@eduard13
Copy link
Contributor

eduard13 commented Jun 5, 2020

@magento run Database Compare, Functional Tests B2B

Copy link
Contributor

@mrtuvn mrtuvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new changes ok with me

@mrtuvn
Copy link
Contributor

mrtuvn commented Jun 7, 2020

Can we proceed next step with QA/QC verify

@ghost ghost assigned ptylek Jun 8, 2020
@ghost ghost removed the Progress: pending review label Jun 8, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-7652 has been created to process this Pull Request
✳️ @ptylek, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

Hi @ptylek @mrtuvn .
Could you put an appropriate label for test coverage?
Thanks!

@mrtuvn
Copy link
Contributor

mrtuvn commented Jun 9, 2020

@engcom-Alfa i don't have permissions for this

@ptylek ptylek added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 10, 2020
@engcom-Echo engcom-Echo self-assigned this Jun 11, 2020
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Jun 11, 2020

✔️ QA Passed

Manual testing scenario:

  1. Install Magento 2.4-develop with sample data;
  2. Go to Catalog - Categories;
  3. Go to Men / Tops / Tanks;
  4. Ad a new subcategory (Category for example);
  5. Save;
  6. Go to Storefront;
  7. Main Menu -> Men ->Tops -> Tanks;

Before: ✖️ The new submenu is at the top and cannot be reached.

Peek 2020-06-11 11-29

After: ✔️ The new submenu is next to Tanks

Peek 2020-06-11 11-25

Checked also on Blank theme

Actual Result: ✔️ The new submenu is next to Tanks

Peek 2020-06-11 11-44

@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 11, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 11, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jun 11, 2020
@eduard13 eduard13 removed their assignment Jun 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 12, 2020

Hi @kishorenagalingam, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 9584d6b into magento:2.4-develop Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend 3rd level of submenu not accessible
8 participants