Skip to content

Frontend customer account order list #28417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

engcom-Charlie
Copy link
Contributor

@engcom-Charlie engcom-Charlie commented May 29, 2020

Description (*)

Fixed frontend customer account list issue, covered by test

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Install Magento 2.4-develop CE+EE branch.
  2. Create 1 category and 1 simple product.
  3. Create customer on Frontend and log in him to Frontend.
  4. Create the same 11 orders with 1 simple product from step 2.
  5. Go to “My Account”.
  6. Go to “My Orders”.
  7. Click page 2 to display 11th order on orders grid.
  8. Select Show=20 per page drop-down.

Actual Result:

“You have placed no orders” message is displayed:

Expected Result:

All 11 orders are displayed on 1 page.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Frontend customer account order list #28488: Frontend customer account order list

@m2-assistant
Copy link

m2-assistant bot commented May 29, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie changed the title Frontend customer account list Frontend customer account order list Jun 3, 2020
@ihor-sviziev ihor-sviziev self-assigned this Jun 3, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jun 3, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7610 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

@magento create issue

@ghost ghost mentioned this pull request Jun 3, 2020
4 tasks
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Create 1 category and 1 simple product;
  2. Create a customer on Frontend and login him to Frontend;
  3. Create the same 11 orders with 1 simple product from step 2;
  4. Go to “My Account”->"My Orders";
  5. Click page 2 to display the 11th order on the orders grid;
  6. Select Show=20 per page from the drop-down menu.

Before: ✖️ “You have placed no orders” message is displayed

Peek 2020-06-03 12-42

After: ✔️ All 11 orders are displayed on 1 page.

Peek 2020-06-03 13-13

@engcom-Kilo engcom-Kilo self-assigned this Jun 3, 2020
@ghost ghost added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 3, 2020
@engcom-Kilo
Copy link
Contributor

Added MFTF test

@engcom-Kilo
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

Failing functional tests looks not related to changes from this Pr, but to be sure I just restarted them

@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo engcom-Kilo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 9, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jun 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7610 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 10, 2020
@magento-engcom-team magento-engcom-team merged commit 38f76f7 into magento:2.4-develop Jun 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 12, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Customer Component: Quote Component: Theme Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] Frontend customer account order list
6 participants