Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFTF: Refactoring admin check url rewrites multiple storeviews product import test #28469

Conversation

kate-kyzyma
Copy link
Contributor

Description (*)

AdminCheckUrlRewritesMultipleStoreviewsProductImportTest is refactored according to the best practices followed by MFTF.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

Run AdminCheckUrlRewritesMultipleStoreviewsProductImportTest in the local environment and verified the test runs successfully.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 2, 2020

Hi @kate-kyzyma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Catalog Component: UrlRewrite Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 2, 2020
@rogyar rogyar self-assigned this Jun 2, 2020
@rogyar
Copy link
Contributor

rogyar commented Jun 2, 2020

@magento run all tests

Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kate-kyzyma. It does look like that for some reason the system cannot generate MFTF tests for the Commerce Edition. Could I ask you to test your changes with the Commerce Edition as well?

Thank you.

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 4, 2020
@dmytro-ch
Copy link
Contributor

@magento run Functional Tests B2B

@dmytro-ch
Copy link
Contributor

Hello @rogyar, I also faced the same issue for other PRs, it seems to be an infrastructure issue. The checks successfully passed after restarting the tests.

@rogyar
Copy link
Contributor

rogyar commented Jun 5, 2020

Hi @dmytro-ch. Thank you for the check

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7623 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Jun 10, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 11, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jun 11, 2020
magento-engcom-team pushed a commit that referenced this pull request Jun 12, 2020
@magento-engcom-team magento-engcom-team merged commit 1e5854c into magento:2.4-develop Jun 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 12, 2020

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kate-kyzyma kate-kyzyma deleted the Refactoring-AdminCheckUrlRewritesMultipleStoreviewsProductImportTest branch June 24, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Catalog Component: UrlRewrite Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants