Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Variable for border-radius #28548

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Use Variable for border-radius #28548

merged 3 commits into from
Aug 24, 2020

Conversation

Scarbous
Copy link
Contributor

@Scarbous Scarbous commented Jun 5, 2020 •
edited by m2-assistant bot
Loading

The border-radius was hard coded, so i changed it to: @button__border-radius

Resolved issues:

  1. resolves [Issue] Use Variable for border-radius #28674: Use Variable for border-radius

@Scarbous
Use Variable for border-radius
eface05 
The border-radius was hard coded, so i changed it to: @button__border-radius
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @Scarbous. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@rogyar rogyar self-assigned this Jun 7, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 7, 2020
@rogyar rogyar added the Cleanup label Jun 7, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7630 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Scarbous thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Jun 9, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

The size of the border-radius is still the same as before (expected)

For example:

screenshot_49

@engcom-Echo engcom-Echo self-assigned this Jun 9, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@slavvka slavvka added this to the 2.4.1 milestone Jun 10, 2020
@slavvka
Copy link
Member

slavvka commented Jun 10, 2020

@magento create issue

1 similar comment
@VladimirZaets
Copy link
Contributor

@magento create issue

@VladimirZaets
Copy link
Contributor

@magento create issue

1 similar comment
@VladimirZaets
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jun 10, 2020
Closed
@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 11, 2020
@ghost ghost added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Jun 11, 2020
@sidolov sidolov added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Aug 13, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 14, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@sidolov sidolov removed this from the 2.4.1 milestone Aug 20, 2020
@magento-engcom-team
Copy link
Contributor

@Scarbous thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

magento-engcom-team pushed a commit that referenced this pull request Aug 24, 2020
@sidolov
ENGCOM-7630: Use Variable for border-radius #28548
aac9be8
@magento-engcom-team magento-engcom-team merged commit 4ab6e3b into magento:2.4-develop Aug 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 24, 2020

Hi @Scarbous, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Use Variable for border-radius
9 participants
@Scarbous @magento-engcom-team @engcom-Alfa @engcom-Echo @slavvka @VladimirZaets @rogyar @sidolov @engcom-Delta