-
Notifications
You must be signed in to change notification settings - Fork 9.4k
MFTF: Replace redundant Xpath for @id
attribute with CSS selector
#28606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Replace redundant Xpath for @id
attribute with CSS selector
#28606
Conversation
Hi @lbajsarowicz. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE |
Hi @rogyar, thank you for the review. |
QA not applicable |
@magento run all tests |
Hi @lbajsarowicz, thank you for your contribution! |
Description (*)
Although there is no difference in performance, readability of CSS selectors is much better, especially when we have elements having it's unique ID attribute. That is why I want to encourage MFTF users to use CSS selectors instead of enforcing Xpath when it's not necessary.
Related Pull Requests
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
N/A
Questions or comments
N/A
Contribution checklist (*)