clear errors when apply new filters

[AbdulRahmanAbouzaid]

Description (*)

Clear error when applying new filters instead of still displaying it which is the wrong behavior as mentioned in this comment

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes No ability to reset filters after an error #8538

Manual testing scenarios (*)

1. Create a new store view (call it "Second Store View" for example);
2. Log in to Admin -> Catalog -> Products;
3. Set up and apply a filter for the newly created store view;
   
4. Now, go to Admin->Stores->All Stores;
5. Delete the created before "Second Store View" store view;
6. Go to Admin->Catalog->Products again;
7. Set up and apply a new filter and the error message will be disappeared.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @AbdulRahmanAbouzaid. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[AbdulRahmanAbouzaid]

@magento give me test instance

[magento-engcom-team]

Hi @AbdulRahmanAbouzaid. Thank you for your request. I'm working on Magento instance for you

[AbdulRahmanAbouzaid]

@magento run all tests

[lenaorobei]

Thanks for this fix. Please add MFTF test to cover expected behavior.

[AbdulRahmanAbouzaid]

@lenaorobei I've provided the mftf using AdminGridFilterDeleteAndVerifyErrorMessageTest
Can you review it please?

[lenaorobei]

Thanks a lot!

Please see minor review comments and suggestions.

[AbdulRahmanAbouzaid]

@magento run all tests

[lenaorobei]

@magento run Functional Tests EE

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-8098 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Oscar]

✔️ QA Passed

Tested according manual scenario described in ticket

Before ✖️

Error message persists after a new filter is submitted

After ✔️

Error message disappeared.

[engcom-Charlie]

@magento run all tests

[m2-assistant]

Hi @AbdulRahmanAbouzaid, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.