Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#: GraphQl mutation. Additional test coverage for customer storeConfig settings. #28761

Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from
Open

magento/magento2#: GraphQl mutation. Additional test coverage for customer storeConfig settings. #28761

wants to merge 5 commits into from

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Jun 17, 2020 •
edited by m2-assistant bot
Loading

Description (*)

PR adds the additional test coverage for the next customer storeConfig options:

  • required_character_classes_number
  • minimum_password_length

Related Pull Requests

#27876

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] magento/magento2#: GraphQl mutation. Additional test coverage for customer storeConfig settings. #37915: magento/magento2#: GraphQl mutation. Additional test coverage for customer storeConfig settings.

@m2-assistant
Copy link

m2-assistant bot commented Jun 17, 2020

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 17, 2020
@atwixfirster
Copy link
Contributor Author

@magento run Integration Tests,WebAPI Tests,Static Tests,Database Compare

@dmytro-ch dmytro-ch self-assigned this Jun 17, 2020
@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 17, 2020
@ghost ghost assigned VladimirZaets Jun 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-7701 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@atwixfirster atwixfirster force-pushed the graphql-storeConfig-customer-settings branch from 5eb3edb to 3c76f6b Compare June 17, 2020 19:21
@atwixfirster
Copy link
Contributor Author

@magento run Integration Tests,WebAPI Tests,Static Tests,Database Compare

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 18, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7701 has been created to process this Pull Request

@atwixfirster
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Magento Health Index,Sample Data Tests CE,Sample Data Tests EE,Sample Data Tests B2B

@atwixfirster
Copy link
Contributor Author

@magento run Unit Tests

@atwixfirster
Copy link
Contributor Author

@magento run Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Lima
Copy link
Contributor

@magento run Unit Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Lima
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Lima
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Lima
Copy link
Contributor

@magento run WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Lima
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 24, 2023
Open
4 tasks
@engcom-Lima
Copy link
Contributor

✔️ QA Passed

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-Dash engcom-Dash self-assigned this Oct 4, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Integration Tests, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Dash
Copy link
Contributor

Moving this PR to 'Merge in Progress'.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

@engcom-Lima engcom-Lima

@engcom-Dash engcom-Dash

@chernenm chernenm

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Project: GraphQL Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] magento/magento2#: GraphQl mutation. Additional test coverage for customer storeConfig settings.
9 participants
@atwixfirster @magento-engcom-team @engcom-Alfa @engcom-Lima @engcom-Dash @VladimirZaets @dmytro-ch @sdzhepa @chernenm