Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17] Merge api-proto with develop #71 #28768

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

le0n4ik
Copy link
Contributor

@le0n4ik le0n4ik commented Jun 17, 2020

Description (*)

Merge actual develop state with api-proto branch

Related Pull Requests

https://github.com/magento/partners-magento2-infrastructure/pull/4
magento/catalog-storefront#100
https://github.com/magento/catalog-storefront-ee/pull/4

Fixed Issues (if relevant)

  1. Fixes [17] Merge api-proto with develop catalog-storefront#71

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 17, 2020

Hi @le0n4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me storefront-2.4 instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@mslabko
Copy link
Member

mslabko commented Jun 18, 2020

@magento run all tests

@mslabko mslabko added the Catalog Storefront don't merge with 2.4-develop. PR for project https://github.com/magento/catalog-storefront/wiki label Jun 18, 2020
@le0n4ik le0n4ik merged commit 7a812cd into storefront-2.4 Jun 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2020

Hi @le0n4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@okorshenko okorshenko deleted the storefront-2.4-merge branch August 25, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Catalog Storefront don't merge with 2.4-develop. PR for project https://github.com/magento/catalog-storefront/wiki Progress: pending review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants