Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed misunderstanding title #29410

Merged
merged 3 commits into from
Aug 19, 2020

Conversation

angelo983
Copy link
Member

@angelo983 angelo983 commented Aug 5, 2020

Description (*)

In order failure page "We received your order!" is not appopriate as the title of the page.

Manual testing scenarios (*)

  1. Checkout an order with Paypal and then click cancel and return to the site
  2. Read at the title of the failure page

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Changed misunderstanding title #29416: Changed misunderstanding title

In order failure page "We received your order!" is not appopriate.
@m2-assistant
Copy link

m2-assistant bot commented Aug 5, 2020

Hi @angelo983. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Aug 6, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Aug 6, 2020
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelo983
Would be good to cover this chenge with MFTF or integration test. Could you do that?

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Aug 6, 2020
@ihor-sviziev
Copy link
Contributor

@magento create issue

@angelo983
Copy link
Member Author

@angelo983
Would be good to cover this chenge with MFTF or integration test. Could you do that?

Ihor, I'm sorry but I'm not confident with MFTF, anyway how would be useful integration test for a label change?

@ihor-sviziev
Copy link
Contributor

I just double checked - seems like we don't really need any test coverage as it will be much-much harder to cover it than the fix itself.

I'll put there no need to cover this change with any type of tests

@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Aug 6, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7967 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Simulate an order failure in checkout
  2. Read at the title of the failure page

Before: ✖️

Screenshot from 2020-08-10 16-05-03

After: ✔️ The user is notified that the order failed

Screenshot from 2020-08-11 16-52-40

@engcom-Charlie engcom-Charlie self-assigned this Aug 11, 2020
@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Aug 12, 2020
@ghost ghost added the Priority: P3 May be fixed according to the position in the backlog. label Aug 13, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 17, 2020
@magento-engcom-team magento-engcom-team merged commit d413dbe into magento:2.4-develop Aug 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2020

Hi @angelo983, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@angelo983 angelo983 deleted the patch-1 branch August 19, 2020 22:17
@sidolov sidolov added this to the 2.4.2 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Checkout Component: Multishipping Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] Changed misunderstanding title
6 participants