-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed misunderstanding title #29410
Conversation
In order failure page "We received your order!" is not appopriate.
Hi @angelo983. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angelo983
Would be good to cover this chenge with MFTF or integration test. Could you do that?
@magento create issue |
Ihor, I'm sorry but I'm not confident with MFTF, anyway how would be useful integration test for a label change? |
I just double checked - seems like we don't really need any test coverage as it will be much-much harder to cover it than the fix itself. I'll put there no need to cover this change with any type of tests |
Hi @ihor-sviziev, thank you for the review. |
Hi @angelo983, thank you for your contribution! |
Description (*)
In order failure page "We received your order!" is not appopriate as the title of the page.
Manual testing scenarios (*)
Contribution checklist (*)
Resolved issues: