#28422 :- Newsletter subscription confirmation email never sent again

[konarshankar07]

Description (*)

This PR will fix the issue with resending newsletter email if user didn't confirmed to the newsletter subscription

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Newsletter subscription confirmation email never sent again #28422

Manual testing scenarios (*)

1. Enable newsletter subscription confirmation ("Need to Confirm" option)
2. Log in with an account which is not subscribed to the newsletter
3. Subscribe to the newsletter from My account > Newsletter Subscription
4. An email asking for subscription confirmation is received.
5. Imagine the user does not confirm, deletes the email, forgets it or anything else, but he does not confirm his newsletter subscription
6. He comes back some time later and wants to subscribe to the newsletter, so he does the process again
7. Subscribe to the newsletter from My account > Newsletter Subscription

Expected Result

Newsletter subscription email will be received

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[konarshankar07]

@magento run all tests

[rogyar]

Hi @konarshankar07. Thanks a lot for your fix.
We need to adjust the unit tests correspondingly to cover the change. The cyclomatic complexity of the exiting method (failing static test) has nothing to do with your changes but you may resolve it as well if you wish. Just keep backward compatibility in mind.

Thank you!

[konarshankar07]

@magento run all tests

[konarshankar07]

Hello @rogyar ...
For fixing cyclomatic complexity can I create a private function? I read the https://devdocs.magento.com/contributor-guide/backward-compatible-development/ doc but it didn't mentioned that we can create any new private function

[rogyar]

Hi @konarshankar07 you may create new private functions. This change does not violate backward compatible development principles.

Thank you!

[VladimirZaets]

Hi @konarshankar07. Thanks for collaboration. Do you have any updates?

[konarshankar07]

@magento run Static Tests

[engcom-Charlie]

Hi @konarshankar07, can you please add a short description to the new method to fix the static test?
Thanks for your collaboration.

[konarshankar07]

Hello @engcom-Charlie ...
Method name is already self explanatory so I don't think we need to add the short description. Let me know your thought
Thanks

[engcom-Charlie]

@konarshankar07 agree with you but it needs to add to fix static test.

[konarshankar07]

@magento run all tests

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8034 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Enable newsletter subscription confirmation (Go to Admin -> Stores -> Configuration -> Customers -> Newsletter and set "Need to Confirm" option to "Yes")
2. Log in with an account which is not subscribed to the newsletter;
3. Subscribe to the newsletter from My account > Newsletter Subscription;
4. An email asking for subscription confirmation is received;
5. Imagine the user does not confirm, deletes the email, forgets it or anything else, but he does not confirm his newsletter subscription;
6. He comes back sometime later and wants to subscribe to the newsletter, so he does the process again;
7. Subscribe to the newsletter from My account > Newsletter Subscription;

Before: ✖️ The confirmation email is never sent again.

After: ✔️ The confirmation email is sent again and we can confirm the newsletter subscription

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-8034 has been created to process this Pull Request

[m2-assistant]

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.