Fix Parameter Tokenizer omitting first char of key

[marvinhinz]

Description (*)

\Magento\Framework\Filter\Template\Tokenizer\Parameter has to use a do-while-loop. not a while loop. Else the first char is ignored because $this->next() set the pointer to the second char before getting the first char. (copied from @bernd-reindl)

Fixed Issues (if relevant)

1. Fixes \Magento\Framework\Filter\Template\Tokenizer\Parameter #29185

Manual testing scenarios (*)

1. Create Custom Directive (for me typo3url with link parameter eg. {{typo3_link url='imprint'}}
2. Use it in template (eg. email footer)
3. Debug the new custom directive process($value, array $parameters, ?string $html) function
4. Take a look at the $parameters array.
5. It should contain url => "imprint" but is actually rl => "imprint"

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @marvinhinz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[marvinhinz]

@magento run all tests

[lbajsarowicz]

According to Magento Definition of Done could you provide automatic tests to cover the change?

[engcom-Charlie]

@magento run all tests

[lbajsarowicz]

✔️ All green from my side.

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-8056 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Create Custom Directive as described in devdocs;
2. Add created before directive to any CMS page ( {{lifetime should_bold="1"}} in my case);
3. Open cms page with the custom directive;

Before: ✖️ $parameters of method "process($value, array $parameters, ?string $html): string" have a parameter "hould_bold"

✖️ and the parameter was not applied

After: ✔️ $parameters of method "process($value, array $parameters, ?string $html): string" have a parameter "should_bold"

✔️ and the parameter was applied

[m2-assistant]

Hi @marvinhinz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.