Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] add new AdminOpenConfigurationStoresPageActionGroup #29827

Merged
merged 5 commits into from
Sep 25, 2020
Merged

[MFTF] add new AdminOpenConfigurationStoresPageActionGroup #29827

merged 5 commits into from
Sep 25, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Aug 31, 2020 •
edited by m2-assistant bot
Loading

This PR add new AdminOpenConfigurationStoresPageActionGroup and use this one instead
<amOnPage url="{{ConfigurationStoresPage.url}}" stepKey="navigateToWYSIWYGConfigPage1"/>
<waitForPageLoad stepKey="wait1"/>

Resolved issues:

  1. resolves [Issue] [MFTF] add new AdminOpenConfigurationStoresPageActionGroup #29848: [MFTF] add new AdminOpenConfigurationStoresPageActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Aug 31, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Backend Component: Tinymce Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 31, 2020
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

lbajsarowicz
lbajsarowicz suggested changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Page does not follow Magento Best Practices.
Are you able to adjust that in scope of this PR?

app/code/Magento/Backend/Test/Mftf/ActionGroup/AdminOpenConfigurationStoresPageActionGroup.xml Outdated
<description>Open configuration stores page.</description>
</annotations>

<amOnPage url="{{ConfigurationStoresPage.url}}" stepKey="goToConfigurationStoresPage"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also deprecate the old Page object and introduce new one that actually follows the Magento Best Practices (AdminConfigurationStoresPage)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbajsarowicz Done

@ghost ghost assigned lbajsarowicz Aug 31, 2020
@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 31, 2020
@sidolov
Copy link
Contributor

sidolov commented Aug 31, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 31, 2020
Closed
@lbajsarowicz
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@lbajsarowicz
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

Failing tests are not related with the scope of change.

@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 2, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 2, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@ghost ghost assigned Usik2203 Sep 4, 2020
@gabrieldagama
Copy link
Contributor

The risk was set tolow due to: the suggested changes shouldn't affect other areas.

@Usik2203 Usik2203 removed their assignment Sep 15, 2020
@Usik2203
Copy link
Contributor Author

Hi @lbajsarowicz
Could i kindly ask you to check this PR ?
Thanks

@ghost ghost assigned sidolov Sep 23, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8259 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 24, 2020
@magento-deployment-service
Copy link

Hi @gabrieldagama, unfortunately there is no ability to deploy `` Magento instance. Please make sure you specify the correct Magento version/branch.

@gabrieldagama
Copy link
Contributor

@magento give me new instance with extensions magento/magento2-jp

@magento-deployment-service
Copy link

Hi @gabrieldagama. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @gabrieldagama, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

magento-engcom-team pushed a commit that referenced this pull request Sep 25, 2020
@sidolov
ENGCOM-8259: [MFTF] add new AdminOpenConfigurationStoresPageActionGroup
f5a75f5 
#29827
@magento-engcom-team magento-engcom-team merged commit f2398f9 into magento:2.4-develop Sep 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 25, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz requested changes

@sidolov sidolov sidolov approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@sidolov sidolov

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Backend Component: Tinymce Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] add new AdminOpenConfigurationStoresPageActionGroup
5 participants
@Usik2203 @sidolov @lbajsarowicz @gabrieldagama @magento-engcom-team