Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1794: [MFTF] Unskip AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest #29895

Merged
merged 13 commits into from
Sep 14, 2020
Merged

#1794: [MFTF] Unskip AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest #29895

merged 13 commits into from
Sep 14, 2020

Conversation

joweecaquicla
Copy link

Description (*)

Unskipped AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest and will run MFTF builds to check and confirm that the test is stable.

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes [MFTF] Unskip AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest adobe-stock-integration#1794

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
96ea4d5 
…CatalogUiVerifyUsedInLinkCategoryGridTest - unskip test
@m2-assistant
Copy link

m2-assistant bot commented Sep 3, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
cbca032 
…CatalogUiVerifyUsedInLinkCategoryGridTest - modified assert image column
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

joweecaquicla added 2 commits September 4, 2020 19:14
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
ef4813c 
…94-unskip-admin-media-gallery-catalog-ui-verify-used-in-link-category-grid-test
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
86e9656 
…CatalogUiVerifyUsedInLinkCategoryGridTest - fixed spacing on data
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
f3ea93f 
…CatalogUiVerifyUsedInLinkCategoryGridTest - modified actiongroup, test and added new category data entity
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

joweecaquicla added 2 commits September 5, 2020 02:39
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
8cea7c9 
…94-unskip-admin-media-gallery-catalog-ui-verify-used-in-link-category-grid-test
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
27a9bef 
…CatalogUiVerifyUsedInLinkCategoryGridTest - modified custom category entity, actiongroup, and test
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

rogyar
rogyar requested changes Sep 7, 2020
View reviewed changes
...lleryCatalogUi/Test/Mftf/Test/AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest.xml Outdated
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, avoid flushing the cache whenever it's possible. This action is slow itself and slows down the consecutive tests significantly. I would strongly recommend clearing the proper cache tags instead

magento2/app/code/Magento/Backend/Test/Mftf/ActionGroup/CliCacheCleanActionGroup.xml

Line 11 in e9190a5

<actionGroup name="CliCacheCleanActionGroup">

@ghost ghost assigned rogyar Sep 7, 2020
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
811861c 
…CatalogUiVerifyUsedInLinkCategoryGridTest - change to cache clean
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
225f554 
…94-unskip-admin-media-gallery-catalog-ui-verify-used-in-link-category-grid-test
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

joweecaquicla added 2 commits September 8, 2020 18:04
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
65690bc 
…94-unskip-admin-media-gallery-catalog-ui-verify-used-in-link-category-grid-test
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
e31ab00 
…CatalogUiVerifyUsedInLinkCategoryGridTest - modified test
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

@joweecaquicla joweecaquicla changed the title [WIP] #1794: [MFTF] Unskip AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest #1794: [MFTF] Unskip AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest Sep 10, 2020
@joweecaquicla
Copy link
Author

The failing sorting test on Functional Tests CE has been fixed in #29909.
Will update this PR once the #29909 has been merged.

@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Sep 10, 2020
sivaschenko
sivaschenko requested changes Sep 10, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @joweecaquicla ! I have a question about the implementation, please see my comment

app/code/Magento/MediaGalleryCatalogUi/Test/Mftf/Data/AdminEnhancedMediaGalleryCategoryData.xml Outdated

<entities xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:DataGenerator/etc/dataProfileSchema.xsd">
<entity name="TestSubCategory" type="category">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for introducing this entity instead of SimpleSubCategory?

Copy link
Author

@joweecaquicla joweecaquicla Sep 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sivaschenko There were instances when the test would fail because the category name did not match, to be more specific, it was the hashed suffix on the category name that did not match so I introduced the new entity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joweecaquicla what was the reason of not matching hashed suffix?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sivaschenko I was not able to investigate that issue thoroughly as I was not able to replicate it in my local environment.

@ghost ghost assigned sivaschenko Sep 10, 2020
joweecaquicla added 2 commits September 11, 2020 23:55
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
2485935 
…94-unskip-admin-media-gallery-catalog-ui-verify-used-in-link-category-grid-test
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
a7a1038 
…CatalogUiVerifyUsedInLinkCategoryGridTest - removed custom category entity and modified test
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento-engcom-team pushed a commit that referenced this pull request Sep 14, 2020
@gabrieldagama
ENGCOM-8189: #1794: [MFTF] Unskip AdminMediaGalleryCatalogUiVerifyUse…
2467834 
…dInLinkCategoryGridTest #29895
@magento-engcom-team magento-engcom-team merged commit 696f423 into magento:2.4-develop Sep 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar requested changes

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@rogyar rogyar

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryCatalogUi Component: MediaGalleryUi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MFTF] Unskip AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest
4 participants
@joweecaquicla @sivaschenko @rogyar @magento-engcom-team