Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix category image is not removed from tmp folder after category save #29906

Merged
merged 8 commits into from
Sep 10, 2020

Conversation

engcom-Golf
Copy link
Contributor

Description (*)

Wrong image name for temporary file was used and its relation couldn't be deleted from the database after moving to the permanent folder

Fixed Issues (if relevant)

  1. Fixes Category image is not removed from tmp folder after category save action if image with same name already exists in catalog/category folder adobe-stock-integration#1792

@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2020

Hi @engcom-Golf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Golf
Copy link
Contributor Author

@magento run all tests

@engcom-Golf engcom-Golf marked this pull request as ready for review September 7, 2020 13:22
@engcom-Golf engcom-Golf changed the title [WIP] fix category image is not removed from tmp folder after category save fix category image is not removed from tmp folder after category save Sep 7, 2020
@sivaschenko sivaschenko added Project: ASI Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Sep 7, 2020
@sivaschenko
Copy link
Member

@engcom-Golf please consider configuring the local git or github account with the matching emails, so that the commits are mapped to the github account

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, @engcom-Golf ! Please see my comments

@ghost ghost assigned engcom-Golf Sep 8, 2020
@sivaschenko
Copy link
Member

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8160 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Sep 8, 2020

✔️ QA Passed

Added additional test step in already existing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/943908/scenarios/4836631

@sivaschenko
Copy link
Member

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 8, 2020
@sivaschenko
Copy link
Member

@magento run all tests

@magento-engcom-team magento-engcom-team merged commit b8ea9b6 into magento:2.4-develop Sep 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2020

Hi @engcom-Golf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryCatalogIntegration Component: MediaGalleryUi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
4 participants