Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1801: User is not scrolled up to the "Login failed. Please check if the Secret Key..." error, and can miss the message #29947

Conversation

yolouiese
Copy link
Contributor

@yolouiese yolouiese commented Sep 8, 2020

Description (*)

Added a modification to scroll to the top of the modal to show the error message after unsuccessful licensing from Media Gallery

Fixed Issues (if relevant)

  1. Fixes User is not scrolled up to the "Login failed. Please check if the Secret Key..." error, and can miss the message adobe-stock-integration#1801

Manual testing scenarios (*)

Preconditions

  1. Install Magento with Adobe Stock Integration
  2. Configured integration in Stores -> Configuration -> Advanced-> System -> Adobe Stock Integration fieldset
  3. Old Media Gallery enabled in Stores -> Configuration -> Advanced-> System -> Media Gallery -> Enable Old Media Gallery - No
  4. Provided API Key (Client ID) . Not provided Client Secret
  5. Multiple images saved to Media Gallery, (four rows of images in my case)
  6. Unlicensed image preview saved to Media Gallery being at the bottom of images

Testing Steps

  1. Go to Content - Media Gallery, click Search Adobe Stock
  2. Scroll to the bottom of the page
  3. Select the previously saved Unlicensed image
  4. Click "three dots" and select License

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…Login failed. Please check if the Secret Key... error, and can miss the message - modified scroll to top script
@m2-assistant
Copy link

m2-assistant bot commented Sep 8, 2020

Hi @yolouiese. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@yolouiese
Copy link
Contributor Author

@magento run all tests

@sivaschenko sivaschenko added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Sep 9, 2020
@ghost ghost assigned sivaschenko Sep 9, 2020
@sivaschenko sivaschenko added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8166 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Teste both on Standalone and NOT Standalone Media Gallery
Peek 2020-09-09 14-29

Manual testing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/1051731/scenarios/5188605

magento-engcom-team pushed a commit that referenced this pull request Sep 10, 2020
…ase check if the Secret Key..." error, and can miss the message #29947
@magento-engcom-team magento-engcom-team merged commit 5541522 into magento:2.4-develop Sep 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2020

Hi @yolouiese, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: MediaGalleryUi Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: ASI Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Archived in project
4 participants