Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1830: Stabilize AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest #30034

Merged
merged 10 commits into from
Sep 23, 2020
Merged

#1830: Stabilize AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest #30034

merged 10 commits into from
Sep 23, 2020

Conversation

joweecaquicla
Copy link

Description (*)

This PR will introduced the following stabilized MFTF tests: AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Stabilize AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest adobe-stock-integration#1830

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

magento/adobe-stock-integration#1830: Stabilize AdminMediaGalleryCata…
e0ea1c3 
…logUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest - modified AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@joweecaquicla
Copy link
Author

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

magento/adobe-stock-integration#1830: Stabilize AdminMediaGalleryCata…
f61da2f 
…logUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest - modified AdminMediaGalleryCatalogUiUsedInCategoryFilterTest
@joweecaquicla
Copy link
Author

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

@joweecaquicla joweecaquicla changed the title [WIP] #1830: Stabilize AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest #1830: Stabilize AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest Sep 14, 2020
rogyar
rogyar reviewed Sep 15, 2020
View reviewed changes
...alleryCatalogUi/Test/Mftf/Test/AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest.xml Outdated
@@ -29,6 +29,8 @@
<after>
<magentoCLI command="config:set cms/wysiwyg/enabled disabled" stepKey="disableWYSIWYG"/>
<actionGroup ref="ResetAdminDataGridToDefaultViewActionGroup" stepKey="resetAdminDataGridToDefaultView"/>
<amOnPage url="{{AdminProductIndexPage.url}}" stepKey="navigateToProductIndex"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joweecaquicla. What do you think about using an existing action group instead of a direct call? As the result, we will rely more on action groups which is part of the good practice

magento2/app/code/Magento/Catalog/Test/Mftf/ActionGroup/GoToProductCatalogPageActionGroup.xml

Line 9 in 0262f14

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

@rogyar rogyar self-assigned this Sep 15, 2020
magento/adobe-stock-integration#1830: Stabilize AdminMediaGalleryCata…
7ec2da9 
…logUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest - applied request changes
@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Sep 15, 2020
@joweecaquicla
Copy link
Author

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

1 similar comment
@sivaschenko
Copy link
Member

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

@ghost ghost assigned sivaschenko Sep 15, 2020
@sivaschenko sivaschenko changed the title [WIP] #1830: Stabilize AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest Stabilize AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest Sep 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8212 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Failed ASI tests are actually skipped, looks like they are executed due to some MFTF framework or infrastructure issue

@joweecaquicla joweecaquicla changed the title Stabilize AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest #1830: Stabilize AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest Sep 16, 2020
@sivaschenko
Copy link
Member

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-18…
5a7fc3b 
…30-stabilize-failing-mftf-tests-in-media-gallery-catalog-ui
@joweecaquicla
Copy link
Author

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

@sidolov
Copy link
Contributor

sidolov commented Sep 18, 2020

@sivaschenko please, move PR to "Merge in progress" column when tests will become green only.

@sivaschenko
Copy link
Member

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

@sivaschenko
Copy link
Member

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

magento-engcom-team pushed a commit that referenced this pull request Sep 23, 2020
@gabrieldagama
ENGCOM-8212: #1830: Stabilize AdminMediaGalleryCatalogUiVerifyUsedInL…
e3f36da 
…inkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest #30034
@magento-engcom-team magento-engcom-team merged commit 522cd96 into magento:2.4-develop Sep 23, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@sivaschenko sivaschenko

@rogyar rogyar

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryCatalogUi Component: MediaGalleryUi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
5 participants
@joweecaquicla @sivaschenko @magento-engcom-team @sidolov @rogyar