#1833: Add ability to disable renditions functionality to stores configuration #30057

joweecaquicla · 2020-09-15T15:32:07Z

Introduction of Media Gallery Renditions functionality is approved in https://jira.corp.magento.com/browse/MC-37383 (SVC failure is approved)

Description (*)

This PR will introduce the ability to disable renditions functionality to stores configuration and additional conditions to rendition-related classes.

Related Pull Requests

Fixed Issues (if relevant)

Fixes Add ability to disable renditions functionality to stores configuration adobe-stock-integration#1833

Manual testing scenarios (*)

Previously Rendition functionality was enabled/disabled based on Enhanced Media Gallery enable/disable value.
Currently t has a separate switch in stores configuration.

"Enable Image Optimization" select with "Yes/No" options is added as the first field of "Media Gallery Image Optimization" fieldset
"Enable Image Optimization" is enabled by default
If renditions are disabled - renditions should not be generated during insertion of the image and during the width/height change.
When renditions are enabled - all renditions should be regenerated.
Renditions functionality should work for both old and new media gallery.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…ns functionality to stores configuration - added enable disable renditions to stores configuration

m2-assistant · 2020-09-15T15:32:10Z

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

…ns functionality to stores configuration - added conditions to renditions-related classes

joweecaquicla · 2020-09-16T08:21:30Z

@magento run all tests

sivaschenko

Thanks for the pull request @joweecaquicla ! Please see my comments

As for the test coverage:
Can you please add an ActionGroup enabling the renditions and use this action group for existing New Media Gallery test suites. I believe that should be enough

sivaschenko · 2020-09-16T11:04:03Z

app/code/Magento/MediaGalleryRenditions/Model/Config.php

@@ -19,6 +19,7 @@ class Config
 {
    private const TABLE_CORE_CONFIG_DATA = 'core_config_data';
    private const XML_PATH_ENABLED = 'system/media_gallery/enabled';


This constant is no longer needed and can be removed

sivaschenko · 2020-09-16T11:04:52Z

app/code/Magento/MediaGalleryRenditions/Model/Config.php

+     *
+     * @return bool
+     */
+    public function isMediaGalleryRenditionsEnabled(): bool


New method introduction is not necessary, isEnabled method should be now based on system/media_gallery_renditions/enabled value

sivaschenko · 2020-09-16T11:05:06Z

app/code/Magento/MediaGalleryRenditions/Plugin/SetRenditionPath.php

@@ -91,7 +91,7 @@ public function beforeExecute(
            $storeId
        ];

-        if (!$this->config->isEnabled()) {
+        if (!$this->config->isEnabled() || !$this->config->isMediaGalleryRenditionsEnabled()) {


no change is needed here

…ns functionality to stores configuration - modifications based on request changes

…ns functionality to stores configuration - additional action group and modifications on media gallery test suites

joweecaquicla · 2020-09-16T15:51:26Z

@magento run all tests

sivaschenko · 2020-09-16T16:24:51Z

@magento run all tests

sivaschenko · 2020-09-16T20:56:03Z

Introduction of Media Gallery Renditions functionality is approved in https://jira.corp.magento.com/browse/MC-37383 (SVC failure is approved)

engcom-Bravo

✔️ QA Passed

Enable Image Optimization option is added under Stores - Configuration - Advanced - System - Media Gallery Renditions

The default value is Yes

When the value is set to Yes, the images added to the content are optimized to the size set in Maximum Width and Maximum Height fields

When the value is set to No, the original image size is inserted into the Content of an Entity

When No and Yes values are changed, and bin/magento queue:consumers:start media.gallery.renditions.update is performed, the images that have already been inserted with original size, are NOT reduced or enlarged.

Manual testing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/1507933/scenarios/5219418

…tions-functionality-to-stores-configuration

sivaschenko · 2020-09-17T14:23:09Z

@magento run all tests

…tions-functionality-to-stores-configuration

joweecaquicla · 2020-09-18T15:56:49Z

@magento run all tests

sidolov · 2020-09-18T16:14:59Z

@sivaschenko SVC failures must be approved.

sivaschenko · 2020-09-21T14:40:23Z

Introduction of Media Gallery Renditions functionality is approved in https://jira.corp.magento.com/browse/MC-37383 (SVC failure is approved)

…o stores configuration #30057

m2-assistant · 2020-09-23T12:32:57Z

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento/adobe-stock-integration#1833: Add ability to disable renditio…

356ef14

…ns functionality to stores configuration - added enable disable renditions to stores configuration

joweecaquicla added the Project: ASI label Sep 15, 2020

joweecaquicla requested a review from sivaschenko September 15, 2020 15:32

ghost added the Progress: pending review label Sep 15, 2020

magento-engcom-team added Component: MediaGalleryRenditions Release Line: 2.4 labels Sep 15, 2020

magento/adobe-stock-integration#1833: Add ability to disable renditio…

27f50e4

…ns functionality to stores configuration - added conditions to renditions-related classes

joweecaquicla changed the title ~~[WIP] #1833: Add ability to disable renditions functionality to stores configuration~~ #1833: Add ability to disable renditions functionality to stores configuration Sep 16, 2020

sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Sep 16, 2020

sivaschenko requested changes Sep 16, 2020

View reviewed changes

ghost assigned sivaschenko Sep 16, 2020

ghost added Progress: needs update and removed Progress: pending review labels Sep 16, 2020

joweecaquicla added 2 commits September 16, 2020 22:11

magento/adobe-stock-integration#1833: Add ability to disable renditio…

1de7ccb

…ns functionality to stores configuration - modifications based on request changes

magento/adobe-stock-integration#1833: Add ability to disable renditio…

4e20d29

…ns functionality to stores configuration - additional action group and modifications on media gallery test suites

joweecaquicla requested a review from sivaschenko September 16, 2020 15:51

magento#30057: Corrected UpdateRenditionsOnConfigChange plugin logic

746ee90

sivaschenko added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 16, 2020

sivaschenko previously approved these changes Sep 16, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Sep 16, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Sep 17, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Sep 17, 2020

engcom-Bravo reviewed Sep 17, 2020

View reviewed changes

sivaschenko added 2 commits September 17, 2020 17:21

magento#30057: Disabled renditions for old media gallery

2773046

Merge branch '2.4-develop' into ASI-1833-add-ability-to-disable-rendi…

e1bbf88

…tions-functionality-to-stores-configuration

Merge branch '2.4-develop' into ASI-1833-add-ability-to-disable-rendi…

bb3822a

…tions-functionality-to-stores-configuration

ghost added Progress: accept and removed Progress: extended testing labels Sep 18, 2020

ghost added Progress: extended testing and removed Progress: accept labels Sep 18, 2020

ghost added Progress: accept and removed Progress: extended testing labels Sep 21, 2020

magento-engcom-team pushed a commit that referenced this pull request Sep 23, 2020

ENGCOM-8223: #1833: Add ability to disable renditions functionality t…

7534dbc

…o stores configuration #30057

magento-engcom-team merged commit 95ba128 into magento:2.4-develop Sep 23, 2020

sivaschenko mentioned this pull request Sep 23, 2020

Added Media Gallery Image Optimization Documenation magento/merchdocs#762

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1833: Add ability to disable renditions functionality to stores configuration #30057

#1833: Add ability to disable renditions functionality to stores configuration #30057

joweecaquicla commented Sep 15, 2020 •

edited by sivaschenko

Loading

m2-assistant bot commented Sep 15, 2020

joweecaquicla commented Sep 16, 2020

sivaschenko left a comment •

edited

Loading

sivaschenko Sep 16, 2020

sivaschenko Sep 16, 2020

sivaschenko Sep 16, 2020

joweecaquicla commented Sep 16, 2020

sivaschenko commented Sep 16, 2020

sivaschenko commented Sep 16, 2020 •

edited

Loading

engcom-Bravo left a comment

sivaschenko commented Sep 17, 2020

joweecaquicla commented Sep 18, 2020

sidolov commented Sep 18, 2020

sivaschenko commented Sep 21, 2020

m2-assistant bot commented Sep 23, 2020

#1833: Add ability to disable renditions functionality to stores configuration #30057

#1833: Add ability to disable renditions functionality to stores configuration #30057

Conversation

joweecaquicla commented Sep 15, 2020 • edited by sivaschenko Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

m2-assistant bot commented Sep 15, 2020

joweecaquicla commented Sep 16, 2020

sivaschenko left a comment • edited Loading

Choose a reason for hiding this comment

sivaschenko Sep 16, 2020

Choose a reason for hiding this comment

sivaschenko Sep 16, 2020

Choose a reason for hiding this comment

sivaschenko Sep 16, 2020

Choose a reason for hiding this comment

joweecaquicla commented Sep 16, 2020

sivaschenko commented Sep 16, 2020

sivaschenko commented Sep 16, 2020 • edited Loading

engcom-Bravo left a comment

Choose a reason for hiding this comment

sivaschenko commented Sep 17, 2020

joweecaquicla commented Sep 18, 2020

sidolov commented Sep 18, 2020

sivaschenko commented Sep 21, 2020

m2-assistant bot commented Sep 23, 2020

joweecaquicla commented Sep 15, 2020 •

edited by sivaschenko

Loading

sivaschenko left a comment •

edited

Loading

sivaschenko commented Sep 16, 2020 •

edited

Loading