Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFTF: Admin Delete CMS Block Test #30359

Merged

Conversation

DmitryTsymbal
Copy link
Contributor

@DmitryTsymbal DmitryTsymbal commented Oct 7, 2020

Description
This PR contains a test for deleting CMS block from grid by Admin User

Steps To reproduce:

1 - Create CMS block
2 - Login as Admin User
3 - Navigate to Content->Blocks
4 - Find Created CMS Block
5 - Delete Created CMS Block
6 - Perform Assertions

Resolved issues:

  1. resolves [Issue] MFTF: Admin Delete CMS Block Test #30372: MFTF: Admin Delete CMS Block Test

@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2020

Hi @DmitryTsymbal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Oct 7, 2020
@rogyar rogyar self-assigned this Oct 7, 2020
@rogyar
Copy link
Contributor

rogyar commented Oct 7, 2020

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@rogyar
Copy link
Contributor

rogyar commented Oct 7, 2020

Hi @DmitryTsymbal. Good job. As the next step (another PR), I would suggest refactoring some existing action groups like the following ones (if applicable).

<actionGroup name="DeleteCMSBlockActionGroup">

@rogyar rogyar added Award: MFTF test coverage Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Oct 7, 2020
rogyar
rogyar previously approved these changes Oct 7, 2020
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are not related to the current changeset

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8316 has been created to process this Pull Request

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 7, 2020
@engcom-Bravo engcom-Bravo self-assigned this Oct 8, 2020
@engcom-Bravo
Copy link
Contributor

@magento create issue

@engcom-Bravo
Copy link
Contributor

QA Not applicable

@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Nov 2, 2020
@magento-engcom-team magento-engcom-team merged commit ceaa9d4 into magento:2.4-develop Nov 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 9, 2020

Hi @DmitryTsymbal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: MFTF test coverage Component: Cms Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] MFTF: Admin Delete CMS Block Test
8 participants