Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Add new AdminClickAddProductToggleAndSelectProductTypeActionGroup #30525

Merged
merged 6 commits into from
Nov 15, 2020
Merged

[MFTF] Add new AdminClickAddProductToggleAndSelectProductTypeActionGroup #30525

merged 6 commits into from
Nov 15, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Oct 17, 2020 •
edited by m2-assistant bot
Loading

This PR add AdminClickAddProductToggleAndSelectProductTypeActionGroup

Resolved issues:

  1. resolves [Issue] [MFTF] Add new AdminClickAddProductToggleAndSelectProductTypeActionGroup #30917: [MFTF] Add new AdminClickAddProductToggleAndSelectProductTypeActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Oct 17, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@rogyar rogyar self-assigned this Oct 18, 2020
@rogyar
Copy link
Contributor

rogyar commented Oct 18, 2020

Hi @Usik2203. Thanks for the refactoring. Good job! Since your edits contain backward-incompatible changes, the best way is to wait for 2.5-develop branch. I'm putting this on hold for now.

Thanks.

@rogyar rogyar added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: on hold labels Oct 18, 2020
@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 19, 2020
@rogyar
Copy link
Contributor

rogyar commented Oct 20, 2020 •
edited
Loading

Hi @Usik2203. Please, refer to my comment that explains a workaround for removing old steps and preserving BC

#30223 (comment)

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests EE , Functional Tests B2B

@Usik2203
Copy link
Contributor Author

Hi @rogyar
I have applied your recommendations
Seems failed test are not related with my changes.
Thanks

rogyar
rogyar reviewed Oct 30, 2020
View reviewed changes
app/code/Magento/Bundle/Test/Mftf/Test/NewProductsListWidgetBundleProductTest.xml Outdated
@@ -36,8 +36,10 @@
<!-- Create a product to appear in the widget, fill in basic info first -->

<actionGroup ref="AdminOpenProductIndexPageActionGroup" stepKey="amOnProductList"/>
<click selector="{{AdminProductGridActionSection.addProductToggle}}" stepKey="clickAddProductToggle"/>
<click selector="{{AdminProductGridActionSection.addBundleProduct}}" stepKey="clickAddBundleProduct"/>
<comment userInput="StepKey Backward Compatibility" stepKey="clickAddProductToggle"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will do the trick. However, it might not be obvious for me as a developer why we add this comment according to the current description. I would recommend putting some meaningful description like

userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"

It applies to all other comments in all your PRs.

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogyar
I have applied your recommendations
Thanks :)

@ghost ghost removed the Progress: on hold label Oct 30, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8439 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

QA not applicable

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie self-assigned this Nov 13, 2020
@engcom-Charlie
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 13, 2020
Closed
@engcom-Charlie engcom-Charlie added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Nov 13, 2020
magento-engcom-team pushed a commit that referenced this pull request Nov 15, 2020
@gabrieldagama
ENGCOM-8439: [MFTF] Add new AdminClickAddProductToggleAndSelectProduc…
c5f2d35 
…tTypeActionGroup #30525
@magento-engcom-team magento-engcom-team merged commit 7e3f72b into magento:2.4-develop Nov 15, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 15, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Bundle Component: Catalog Component: Downloadable Component: GroupedProduct Component: Swatches Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Add new AdminClickAddProductToggleAndSelectProductTypeActionGroup
6 participants
@Usik2203 @rogyar @magento-engcom-team @engcom-Bravo @engcom-Charlie @sidolov