magento/magento2-page-builder#558: Developer can style content types … #30565
Conversation
…output differently per viewport - Added body id in Storefront, in tinymce4 in admin
|
Hi @hannahnida. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
ghost
added
the
|
@magento run all tests |
…output differently per viewport - Fixed quote marks
|
@magento run all tests |
| @@ -8,6 +8,7 @@ | |||
| <page layout="3columns" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd"> | |||
| <update handle="default_head_blocks"/> | |||
| <body> | |||
| <attribute name="id" value="html-body"/> | |||
There was a problem hiding this comment.
@hannahnida I don't see what exactly should be done in the task you mentioned - but adding an ID to the body is not really seems correct solution here. Could you explain why it's needed? Why can't we use class here for instance? Unfortunately it's not clear what the styling issue you have
There was a problem hiding this comment.
@ihor-sviziev We need to add this id to have a higher level of CSS specificity over less styles. This work is going in the scope of Page Builder story to eliminate the usage of inline styles. Feel free to ask me for any details.
There was a problem hiding this comment.
So why can't we use class here? I believe if you'll use body.some-class .my-style it should work approximately the same as #my-body-id .my-style
There was a problem hiding this comment.
Unfortunately, no. The class does not give enough specificity value. For more information, you could read https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity and visual specificity sheet https://specifishity.com/
…output differently per viewport - Fixed tinymce image selector
…output differently per viewport - Fixed tinymce image selector
…t types output differently per viewport - Fixed tinymce image selector" This reverts commit 754eb5a.
|
@magento run all tests |
…tent-type-style-attribute-removal
|
@magento run all tests |
sidolov
added
Priority: P2
|
@magento import pull request to magento-obsessive-owls/magento2ce |
|
@omiroshnichenko the pull request successfully imported. |
|
Hi @hannahnida, thank you for your contribution! |
…output differently per viewport - Added body id in Storefront, added body id in tinymce4 in admin
Description (*)
Changes are related to Issue 558, body id for storefront and for tinymce4 in admin area are necessary for the new styles to work properly.
Related Pull Requests
magento/magento2-page-builder#621
https://github.com/magento/magento2-page-builder-ee/pull/171
https://github.com/magento/partners-magento2ee/pull/387
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)