FIX Perfomance Issue for Backend EDIT of CMS #30936

[larsroettig]

Description (*)

Edit pages in Backend was loading all CMS Pages to use only one for render the form.

Here it creates new collection without filter the foreach loads the collection.
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Cms/Model/Page/DataProvider.php#L103

Related Pull Requests

• None

Fixed Issues (if relevant)

1. Fixes Perfomance:Cms/Model/Page/DataProvider.php#L103 loads full collection without any filter #30936

Manual testing scenarios (*)

1. Open Edit CMS EDIT Page in Backend
2. Save CMS Page in Backend

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @larsroettig. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[larsroettig]

@magento give me test instance

[magento-deployment-service]

Hi @larsroettig. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @larsroettig, here is your Magento Instance: https://32ae593d2aea7a9f90965dfd60db1177.instances.magento-community.engineering
Admin access: https://32ae593d2aea7a9f90965dfd60db1177.instances.magento-community.engineering/admin_be39
Login: 0ec38db7
Password: d3bfb5a6c1ab

[larsroettig]

@magento run all tests

[gabrieldagama]

Hi @larsroettig, thanks for your contribution! Well, good catch on that one. Please follow some comments below.

Also, I believe some of the failed tests may be related to these PR changes, can you have a look at them?

Thanks!

[engcom-Charlie]

Hi @larsroettig, could you please update your PR accordingly to #30943 (review)?
Thank you.

[larsroettig]

@engcom-Charlie surre will update today sorry i missed this notfication

[engcom-Charlie]

Hi @larsroettig, please update your PR accordingly to #30943 (review). Otherwise, we can't proceed with your PR.
Thank you.

[gabrieldagama]

Hi @engcom-Charlie, thanks for updating this PR, I've got just a couple more comments, but it is looking very good!

Thanks.

[gabrieldagama]

Suggested change

	$page = $this->pageFactory->create()
	->setData($data);
	return $this->pageFactory->create()
	->setData($data);

[engcom-Charlie]

@magento run all tests

[magento-engcom-team]

Hi @gabrieldagama, thank you for the review.
ENGCOM-8576 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

The result is the same as in the report above #30943 (comment)

[m2-assistant]

Hi @larsroettig, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.