Stopping old queue consumers during upgrade

[swnsma]

Description (*)

Put poison pill after each 'setup:upgrade' execution.

Fixed Issues (if relevant)

1. Fixes Queue consumers #23540

Steps for testing:

1. Check "version" value in "queue_poison_pill" table in Magento instance database.
2. Upgrade Magento instance.
3. Verify "version" value in "queue_poison_pill" table has changed in Magento instance database.
4. Execute queue:consumers:restart command.
5. Verify "version" value in "queue_poison_pill" table has changed in Magento instance database.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @swnsma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[hostep]

This also kind-of fixes magento/community-features#181 and problem 2 mentioned over here I think.

Not sure if we still need a dedicated bin/magento command as well, or if doing this in setup:upgrade is enough. But for me, it would be enough.

[swnsma]

@magento run all tests

[coderimus]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Magento Health Index

[coderimus]

@magento run Functional Tests B2B, Functional Tests CE, Magento Health Index

[coderimus]

Hello @swnsma
Thank you for the fix! As for me, it is a really great solution which removes headache for everyone who uses the MQ in the Magento. I think that the approach you provided is applicable and it uses in other core modules also, as I can see. No need to have another CI command in that case 👍

I approve this PR in a comment for now but we have the Health Index failed and without assistance from the core team we are not able to move forward so let's call @sivaschenko and @sidolov for help :) Please, assist me with the next step: just approve it and move for testing or we need to do something else in case of failed Health Index with the Difference with mainline detected message?

[sivaschenko]

Thanks for the pull request @swnsma !

I am moving this pull request to "To Apporve" status to process internal approval.

Approval ticket: https://jira.corp.magento.com/browse/MC-40323

cc @sidolov

[engcom-Alfa]

@magento run Functional Tests B2B, Magento Health Index

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[PascalBrouwers]

@sidolov @sivaschenko can we get this merged?

[ihor-sviziev]

also pinging @ishakhsuvarov

[engcom-Hotel]

Raised new internal approval request JIRA ticket on the adobe portal for Health Index test failure. Waiting for the approvals.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ishakhsuvarov]

@ihor-sviziev I am working to push this ticket forward

[ishakhsuvarov]

@swnsma @ihor-sviziev This actually got merged, however last commit with 2.4 sync did not get included in the internal merge, thus creating this confusiong situation.

Not sure why github thinks it's "closed" and not "merged" but there is 0 files and commits in the changeset.

Sorry for the confusion.

[swnsma]

@ishakhsuvarov, thank you!
After so many months this seems to be Christmas Miracle! :)

[fritzmg]

Since the exact commits are lost (or may be someone has a link?) - was this actually already released, or will this be in the next release?

[hostep]

Yes, it will be included in Magento 2.4.6 (it's included in 2.4.6-beta1 at least)

And I've found these commits: https://github.com/magento/magento2/search?q=%22magento%2Fmagento2%2323540%22&type=commits