Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed CliIndexerReindexActionGroup action group usage for Customer module #31776

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Removed CliIndexerReindexActionGroup action group usage for Customer module #31776

merged 2 commits into from
Feb 5, 2021

Conversation

sergiy-v
Copy link
Contributor

Description

Remove CliIndexerReindexActionGroup action group usage or change value for it from tests to improve execution time for the Customer and GroupedProduct modules.

@sergiy-v
Removed usage or changed value of CliIndexerReindexActionGroup action…
499c1fc 
… group for Customer and GroupedProduct modules
@m2-assistant
Copy link

m2-assistant bot commented Jan 20, 2021

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Customer Component: GroupedProduct Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 20, 2021
@sergiy-v sergiy-v changed the title Removed CliIndexerReindexActionGroup action group usage for Customer module [WIP] Removed CliIndexerReindexActionGroup action group usage for Customer module Jan 20, 2021
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Semantic Version Checker

@sergiy-v sergiy-v changed the title [WIP] Removed CliIndexerReindexActionGroup action group usage for Customer module Removed CliIndexerReindexActionGroup action group usage for Customer module Jan 20, 2021
@sergiy-v
Copy link
Contributor Author

Looks like all issues in functional tests are related to 'vimeo video'.
PR is ready to review.

@ihor-sviziev ihor-sviziev self-assigned this Jan 21, 2021
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jan 21, 2021 •
edited
Loading

@sergiy-v, your changes look good to me.
The Vimeo issues were already fixed. Could you merge recent changes from 2.4-develop?

@sergiy-v
Copy link
Contributor Author

@sergiy-v, your changes look good to me.
The Vimeo issues were already fixed. Could you merge recent changes from 2.4-develop?

@ihor-sviziev thank you for the hint, I'll update all opened PRs today.
Thank you.

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Semantic Version Checker

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests CE

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8699 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 24, 2021
@sergiy-v
Copy link
Contributor Author

@magento run WebAPI Tests, Unit Tests, Static Tests, Sample Data Tests EE, Sample Data Tests CE, Sample Data Tests B2B, Magento Health Index, Integration Tests, Database Compare

@ihor-sviziev
Copy link
Contributor

@sidolov @sivaschenko, should we put here s2 p2 labels similar to #31864?

@sidolov sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 29, 2021
@engcom-Delta engcom-Delta self-assigned this Feb 1, 2021
@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

magento-engcom-team pushed a commit that referenced this pull request Feb 5, 2021
@gabrieldagama
ENGCOM-8699: Removed CliIndexerReindexActionGroup action group usage …
3c04135 
…for Customer module #31776
@magento-engcom-team magento-engcom-team merged commit 73d36f8 into magento:2.4-develop Feb 5, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 5, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Customer Component: GroupedProduct Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Type: Test Coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sergiy-v @ihor-sviziev @magento-engcom-team @engcom-Delta @gabrieldagama @sidolov