-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update laminas/laminas-validator dependency to PHP 8 compatible version #31797
Update laminas/laminas-validator dependency to PHP 8 compatible version #31797
Conversation
Hi @vlmed. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vlmed thanks for the pull request! Can you please also update composer lock file in https://github.com/magento/partners-magento2ee as well and link the EE pull request using the related PR section.
@magento run all tests |
Hello @sivaschenko , |
@coderimus @vlmed php8-develop branch was updated today from 2.4-develop with test fixes, let's update the branch and rerun tests. (I don't think there have been any tests launched in ee PR, but it's ok to run tests only on CE since PRs are linked) |
…e_laminas_validator_dependency_to_php8
Update balances and linked the related PR @magento run all tests |
@magento run Functional Tests EE |
@sivaschenko related PR is ready for testing |
@vlmed The versions in CE and EE pull requests are different (2.14.2 and 2.14.0). Can you please update both composer.locks |
…as_validator_dependency_to_php8
c55e0fe
to
2ad9c0d
Compare
Hello @sivaschenko . I have upgraded composer.lock and fix merge conflicts. |
@magento run all tests |
Hi @vlmed, thank you for your contribution! |
Description (*)
Updated
laminas/laminas-validator
dependency version.Related Pull Requests
https://github.com/magento/partners-magento2ee/pull/456
Fixed Issues (if relevant)
Fixes #31781
Contribution checklist (*)