Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated laminas-dependency-plugin #31858

Conversation

ProkopovVitaliy
Copy link
Contributor

@ProkopovVitaliy ProkopovVitaliy commented Jan 27, 2021

Description (*)

Updated laminas-dependency-plugin

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/472

Fixed Issues (if relevant)

  1. Fixes Update laminas/laminas-dependency-plugin dependency to PHP 8 compatible version #31174

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 27, 2021

Hi @ProkopovVitaliy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run all tests

1 similar comment
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@sivaschenko, could you provide some info on why the tests are failing without build reports?

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the invalid JSON in the composer.lock file?

@sivaschenko
Copy link
Member

Confirmed, let's proceed with ^2.1.0. @ProkopovVitaliy can you please also create related EE PR?

@hostep
Copy link
Contributor

hostep commented Feb 4, 2021

Ok, no problem here, I just wonder why they then picked that constraint for 2.4.2, but we will probably never know ...

@ProkopovVitaliy
Copy link
Contributor Author

Confirmed, let's proceed with ^2.1.0. @ProkopovVitaliy can you please also create related EE PR?

@sivaschenko created related PR.

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@sivaschenko could you check why all the tests started failing?

@sivaschenko
Copy link
Member

@ihor-sviziev @ProkopovVitaliy the tests are failing because of conflicts

@ProkopovVitaliy
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests

@ProkopovVitaliy
Copy link
Contributor Author

@magento run Functional Tests B2B

@magento magento deleted a comment from magento-engcom-team Feb 15, 2021
@sivaschenko
Copy link
Member

@magento run all tests

@magento magento deleted a comment from magento-engcom-team Feb 15, 2021
@magento magento deleted a comment from magento-engcom-team Feb 15, 2021
@sivaschenko
Copy link
Member

@magento run all tests

@mmansoor-magento mmansoor-magento merged commit 9b36799 into magento:php8-develop Feb 16, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 16, 2021

Hi @ProkopovVitaliy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants