Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Framework Api interfaces #7 #32069

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Mark Framework Api interfaces #7 #32069

merged 1 commit into from
Apr 13, 2021

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Feb 10, 2021 •
edited
Loading

Description (*)

Following interfaces marked as API

lib/internal/Magento/Framework/Stdlib/DateTime/Timezone/LocalizedDateToUtcConverterInterface.php
lib/internal/Magento/Framework/TestFramework/Unit/Autoloader/GeneratorInterface.php
lib/internal/Magento/Framework/Translate/Inline/ProviderInterface.php
lib/internal/Magento/Framework/TranslateInterface.php
lib/internal/Magento/Framework/Url/ModifierInterface.php
lib/internal/Magento/Framework/Url/RouteParamsPreprocessorInterface.php
lib/internal/Magento/Framework/Validator/Constraint/OptionInterface.php
lib/internal/Magento/Framework/Validator/HTML/AttributeValidatorInterface.php
lib/internal/Magento/Framework/Validator/HTML/TagValidatorInterface.php
lib/internal/Magento/Framework/Validator/HTML/WYSIWYGValidatorInterface.php
lib/internal/Magento/Framework/View/Asset/ContentProcessorInterface.php
lib/internal/Magento/Framework/View/Asset/ContextInterface.php
lib/internal/Magento/Framework/View/Asset/LockerProcessInterface.php
lib/internal/Magento/Framework/View/Asset/MergeStrategyInterface.php
lib/internal/Magento/Framework/View/Asset/MergeableInterface.php
lib/internal/Magento/Framework/View/Asset/PreProcessor/FilenameResolverInterface.php
lib/internal/Magento/Framework/View/Design/Fallback/Rule/RuleInterface.php
lib/internal/Magento/Framework/View/Design/FileResolution/Fallback/ResolverInterface.php
lib/internal/Magento/Framework/View/Design/Theme/Customization/ConfigInterface.php
lib/internal/Magento/Framework/View/Design/Theme/Customization/FileAssetInterface.php
lib/internal/Magento/Framework/View/Design/Theme/Customization/FileInterface.php
lib/internal/Magento/Framework/View/Design/Theme/CustomizationInterface.php
lib/internal/Magento/Framework/View/Design/Theme/File/CollectionInterface.php
lib/internal/Magento/Framework/View/Design/Theme/FileInterface.php
lib/internal/Magento/Framework/View/Design/Theme/Image/PathInterface.php
lib/internal/Magento/Framework/View/Design/Theme/ResolverInterface.php
lib/internal/Magento/Framework/View/Design/Theme/ThemeProviderInterface.php

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Mark Framework interfaces as API part 7 #32034

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

CC @sivaschenko

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 10, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn mrtuvn force-pushed the api-interfaces-mark-7 branch from cfb165c to 2011556 Compare February 10, 2021 04:33
@mrtuvn mrtuvn changed the base branch from 2.4-develop to 2.5-develop February 10, 2021 04:34
@coderimus coderimus self-assigned this Feb 10, 2021
coderimus
coderimus suggested changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrtuvn thank you for the adjustments. There is one point explained to me: the @since will be set automatically during the merge. Please, remove it :)

@mrtuvn mrtuvn force-pushed the api-interfaces-mark-7 branch from 2011556 to 6860212 Compare February 11, 2021 08:22
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 11, 2021

Updated as your suggestion

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 14, 2021

@magento run all tests

@coderimus coderimus added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 14, 2021
@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Feb 14, 2021
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 3, 2021

Re-targeted PR branch to 2.4-develop as internal discussed with @gabrieldagama

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 3, 2021

@magento run all tests

@engcom-Oscar engcom-Oscar added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Apr 5, 2021
@engcom-Foxtrot engcom-Foxtrot self-assigned this Apr 5, 2021
@gabrieldagama gabrieldagama changed the base branch from 2.4-develop to api-changes-develop April 13, 2021 10:07
@gabrieldagama
Copy link
Contributor

@magento import code to https://github.com/magento-engcom/magento2ce

@magento-engcom-team
Copy link
Contributor

@gabrieldagama the branch with code successfully imported intomagento-engcom/magento2ce repository. Branch name: imported-magento-magento2-32069.

@magento-cicd2 magento-cicd2 merged commit 5708a54 into magento:api-changes-develop Apr 13, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2021

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderimus coderimus coderimus approved these changes

Assignees

@coderimus coderimus

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Stdlib Component: TestFramework Component: Translate Component: TranslateInterface Component: Url Component: Validator Component: View Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Project: API Changes QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark Framework interfaces as API part 7
7 participants
@mrtuvn @magento-engcom-team @gabrieldagama @coderimus @magento-cicd2 @engcom-Foxtrot @engcom-Oscar