Mark Framework interfaces as API part 9

[mrtuvn]

Description (*)

Marked following interfaces as API + Added strict_types

lib/internal/Magento/Framework/View/File/FileList/CollateInterface.php
lib/internal/Magento/Framework/View/Helper/SecureHtmlRender/SecurityProcessorInterface.php
lib/internal/Magento/Framework/View/Layout/Argument/UpdaterInterface.php
lib/internal/Magento/Framework/View/Layout/Condition/VisibilityConditionInterface.php
lib/internal/Magento/Framework/View/Layout/GeneratorInterface.php
lib/internal/Magento/Framework/View/Layout/LayoutCacheKeyInterface.php
lib/internal/Magento/Framework/View/Layout/ProcessorInterface.php
lib/internal/Magento/Framework/View/Layout/ReaderInterface.php
lib/internal/Magento/Framework/View/Model/PageLayout/Config/BuilderInterface.php
lib/internal/Magento/Framework/View/Page/Config/RendererInterface.php
lib/internal/Magento/Framework/View/TemplateEngine/Xhtml/Compiler/AttributeInterface.php
lib/internal/Magento/Framework/View/TemplateEngine/Xhtml/Compiler/CdataInterface.php
lib/internal/Magento/Framework/View/TemplateEngine/Xhtml/Compiler/CommentInterface.php
lib/internal/Magento/Framework/View/TemplateEngine/Xhtml/Compiler/Directive/DirectiveInterface.php
lib/internal/Magento/Framework/View/TemplateEngine/Xhtml/Compiler/Element/ElementInterface.php
lib/internal/Magento/Framework/View/TemplateEngine/Xhtml/Compiler/TextInterface.php
lib/internal/Magento/Framework/View/TemplateEngine/Xhtml/ResultInterface.php
lib/internal/Magento/Framework/View/TemplateEngineInterface.php
lib/internal/Magento/Framework/View/Xsd/Media/TypeDataExtractorInterface.php
lib/internal/Magento/Framework/Webapi/CustomAttribute/PreprocessorInterface.php
lib/internal/Magento/Framework/Webapi/CustomAttribute/ServiceTypeListInterface.php
lib/internal/Magento/Framework/Webapi/Rest/Request/DeserializerInterface.php

marked references api/class related
lib/internal/Magento/Framework/View/Helper/SecureHtmlRender/TagData.php
lib/internal/Magento/Framework/View/Helper/SecureHtmlRender/EventHandlerData.php
lib/internal/Magento/Framework/View/PageLayout/Config.php

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Mark Framework interfaces as API part 9 #32036

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[mrtuvn]

Rebased 2.5-develop branch

[eduard13]

@magento run all tests

[mrtuvn]

Public type 'Magento\Framework\View\Model\PageLayout\Config\BuilderInterface' references following non-public types:
\Magento\Framework\View\PageLayout\Config
Seems add api annotation got issue fail static tests ( Class reference in interfaces have any non-public methods will make test fails)
Magento\Test\Integrity\PublicCodeTest->testAllPHPClassesReferencedFromPublicClassesArePublic()
CC: @sivaschenko

[eduard13]

@mrtuvn, looks like we'll have to mark the referenced classes as api as well.

[mrtuvn]

@eduard13 done! + Fixed static
@magento run all tests

[eduard13]

Hi @mrtuvn, please review the below minor comment, and can you please declare the strict types for all the classes as well?

Thank you.

[mrtuvn]

@magento run all tests

[mrtuvn]

@magento run Functional Tests CE

[mrtuvn]

Re-targeted PR branch to 2.4-develop as internal discussed with @gabrieldagama

[mrtuvn]

@magento run all tests

[mrtuvn]

@magento run Functional Tests B2B, Integration Tests

[gabrieldagama]

@magento import code to https://github.com/magento-engcom/magento2ce

[magento-engcom-team]

@gabrieldagama the branch with code successfully imported intomagento-engcom/magento2ce repository. Branch name: imported-magento-magento2-32151.

[m2-assistant]

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.