-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Framework Interfaces as API part 3 #32156
Mark Framework Interfaces as API part 3 #32156
Conversation
Hi @mrtuvn. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
3d88904
to
c2d5157
Compare
rebased branch 2.5-develop |
@magento run all tests |
Public type 'Magento\Framework\DB\MapperInterface' references following non-public types: |
Fixed static tests fail |
c2d5157
to
45a9436
Compare
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
45a9436
to
7d38777
Compare
@mrtuvn please update the PR description (for some reasons I don’t have the permission), Related Pull Requests section with the PR that I mentioned, so it will be used on building the environment. |
Added related PR |
@magento run Static Tests |
@magento run all tests |
@gabrieldagama the branch with code successfully imported into |
Hi @mrtuvn, thank you for your contribution! |
Description (*)
The following interfaces marked as API
lib/internal/Magento/Framework/Async/CancelableDeferredInterface.php
lib/internal/Magento/Framework/Async/DeferredInterface.php
lib/internal/Magento/Framework/Autoload/AutoloaderInterface.php
lib/internal/Magento/Framework/Backup/SourceFileInterface.php
lib/internal/Magento/Framework/Cache/ConfigInterface.php
lib/internal/Magento/Framework/Cache/StaleCacheNotifierInterface.php
lib/internal/Magento/Framework/Code/Generator/CodeGeneratorInterface.php
lib/internal/Magento/Framework/Code/Minifier/AdapterInterface.php
lib/internal/Magento/Framework/Code/Reader/ClassReaderInterface.php
lib/internal/Magento/Framework/Code/ValidatorInterface.php
lib/internal/Magento/Framework/Component/ComponentRegistrarInterface.php
lib/internal/Magento/Framework/Crontab/CrontabManagerInterface.php
lib/internal/Magento/Framework/Crontab/TasksProviderInterface.php
lib/internal/Magento/Framework/Css/PreProcessor/ErrorHandlerInterface.php
lib/internal/Magento/Framework/DB/DataConverter/DataConverterInterface.php
lib/internal/Magento/Framework/DB/LoggerInterface.php
lib/internal/Magento/Framework/DB/MapperInterface.php
lib/internal/Magento/Framework/DB/Query/BatchIteratorInterface.php
lib/internal/Magento/Framework/DB/QueryInterface.php
lib/internal/Magento/Framework/DB/Select/QueryModifierInterface.php
lib/internal/Magento/Framework/DB/Select/RendererInterface.php
lib/internal/Magento/Framework/DB/Sequence/SequenceInterface.php
lib/internal/Magento/Framework/DB/Sql/ExpressionInterface.php
lib/internal/Magento/Framework/Data/Collection/Db/FetchStrategyInterface.php
lib/internal/Magento/Framework/Data/Collection/EntityFactoryInterface.php
lib/internal/Magento/Framework/Data/CollectionDataSourceInterface.php
lib/internal/Magento/Framework/Data/CollectionModifierInterface.php
lib/internal/Magento/Framework/Data/SearchResultInterface.php
lib/internal/Magento/Framework/Data/SearchResultProcessorInterface.php
lib/internal/Magento/Framework/Data/ValueSourceInterface.php
lib/internal/Magento/Framework/DataObject/IdentityGeneratorInterface.php
lib/internal/Magento/Framework/DataObject/IdentityInterface.php
lib/internal/Magento/Framework/DataObject/IdentityValidatorInterface.php
lib/internal/Magento/Framework/DataObject/KeyValueObjectInterface.php
Marked api as references
lib/internal/Magento/Framework/Api/CriteriaInterface (by lib/internal/Magento/Framework/DB/MapperInterface.php)
Should merge this before PR related below to avoid conflicts same file
Dependent Pull Requests
magento/magento2ce#32135
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)