Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[32017] Marked Directory, Downloadable, Eav and Elasticsearch interfaces as API #32161

Closed
wants to merge 3 commits into from
Closed

[32017] Marked Directory, Downloadable, Eav and Elasticsearch interfaces as API #32161

wants to merge 3 commits into from

Conversation

Usik2203
Copy link
Contributor

Description (*)

This PR fixes #32017

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Mark Directory, Downloadable, Eav and Elasticsearch interfaces as API #32017

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 15, 2021

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Feb 15, 2021
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 15, 2021
@Usik2203
Copy link
Contributor Author

@magento run all tests

@coderimus coderimus self-assigned this Feb 15, 2021
@coderimus coderimus added this to the 2.5 milestone Feb 15, 2021
@coderimus coderimus added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 15, 2021
coderimus
coderimus suggested changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Usik2203 thank you for the adjustments. Please, check my comments about the empty lines. Everything else good 👍

...code/Magento/Eav/Model/ResourceModel/Attribute/DefaultEntityAttributes/ProviderInterface.php Outdated
namespace Magento\Eav\Model\ResourceModel\Attribute\DefaultEntityAttributes;

/**
* Interface \Magento\Eav\Model\ResourceModel\Attribute\DefaultEntityAttributes\ProviderInterface
*
* @api
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove an empty line after the @api

app/code/Magento/Eav/Model/Entity/Setup/PropertyMapperInterface.php Outdated
namespace Magento\Eav\Model\Entity\Setup;

/**
* Interface \Magento\Eav\Model\Entity\Setup\PropertyMapperInterface
*
* @api
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove an empty line after the @api

app/code/Magento/Eav/Model/Entity/Attribute/Backend/BackendInterface.php Outdated
@@ -11,6 +13,8 @@
* Backend is responsible for saving the values of the attribute
* and performing pre and post actions
*
* @api
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove an empty line after the @api

app/code/Magento/Eav/Model/Entity/Attribute/AttributeInterface.php Outdated
namespace Magento\Eav\Model\Entity\Attribute;

/**
* Interface \Magento\Eav\Model\Entity\Attribute\AttributeInterface
*
* @api
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove an empty line after the @api

@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203
Copy link
Contributor Author

Hi @coderimus
I have applied your recommendations .
Thanks !

@coderimus
Copy link
Contributor

@Usik2203 thank you for the adjustments 👍

@magento-engcom-team
Copy link
Contributor

Hi @coderimus, thank you for the review.
ENGCOM-8763 has been created to process this Pull Request

@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203 Usik2203 mentioned this pull request Apr 13, 2021
Merged
@Usik2203 Usik2203 changed the base branch from 2.5-develop to 2.4-develop April 13, 2021 11:56
@Usik2203 Usik2203 changed the base branch from 2.4-develop to 2.5-develop April 13, 2021 11:57
@gabrieldagama
Copy link
Contributor

Closed in favour of #32726

@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2021

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderimus coderimus coderimus approved these changes

Assignees

@coderimus coderimus

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Directory Component: Downloadable Component: Eav Component: Elasticsearch Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes Release Line: 2.5
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

Mark Directory, Downloadable, Eav and Elasticsearch interfaces as API
4 participants
@Usik2203 @coderimus @magento-engcom-team @gabrieldagama