Skip to content

Allow for preconnect, dns-prefetch and other link tags #32287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

navarr
Copy link
Member

@navarr navarr commented Feb 25, 2021

Adding simple tags like <link rel="preconnect" href="//cdn-ws.turnto.com"/> currently requires a block and template, but could easily be injected into the head through layout updates

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Allow for preconnect, dns-prefetch and other link tags #32380: Allow for preconnect, dns-prefetch and other link tags

Adding simple tags like `<link rel="preconnect" href="//cdn-ws.turnto.com"/>` currently requires a block and template, but could easily be injected into the head through layout updates
@m2-assistant
Copy link

m2-assistant bot commented Feb 25, 2021

Hi @navarr. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@tanghongtanghong
Copy link

_![image](https://user-images.githubusercontent.com/50584758/109270060-7290c200-7848-11eb-9edb-dc5513b7d8e0.png)_

@gabrieldagama
Copy link
Contributor

@magento run all tests

@gabrieldagama gabrieldagama added the Priority: P3 May be fixed according to the position in the backlog. label Mar 4, 2021
@gabrieldagama
Copy link
Contributor

@magento create issue

@ihor-sviziev ihor-sviziev marked this pull request as ready for review February 12, 2025 11:20
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Feb 24, 2025
@engcom-Charlie engcom-Charlie self-assigned this Mar 6, 2025
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

Hi @navarr,

Thank you for the contribution!

I have raised a internal approval JIRA for the SVC failure. Moving this PR to Pending Approval now. We will proceed ahead on this once will get all the required approvals.
image

@engcom-Charlie engcom-Charlie moved this from Ready for Testing to Pending Approval in Community Dashboard Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: View Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Project: Community Picked PRs upvoted by the community Release Line: 2.4 Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Pending Approval
Development

Successfully merging this pull request may close these issues.

[Issue] Allow for preconnect, dns-prefetch and other link tags
9 participants