Feature/32442 delete laminas form from composer

[AndreyChorniy]

Description (*)

This PR created for delete package laminas/laminas-form

Related Pull Requests

Fixed Issues (if relevant)

Resolves #32442

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @AndreyChorniy. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[AndreyChorniy]

@magento run all tests

[ihor-sviziev]

It seems like your changes broke some functionality. Please review and fix test failures.

[AndreyChorniy]

@magento run all tests

[AndreyChorniy]

Hello @ihor-sviziev,
It seems that a couple of extensions which were as a dependency for laminas/laminas-form, used in tests and this is broke them after deleting.
So as the solution I decided to install two packages, and for now, we can see that tests passed.
But I have a question here.
Is this is a good solution to install these packages separately? Or do we need to fix issues using some other classes?

[ihor-sviziev]

@AndreyChorniy, from my perspective, it seems like we should check if it is used only in the tests - better to fix tests with alternatives or add these dependencies to the require-dev section instead. What do you think about it?

[ihor-sviziev]

@AndreyChorniy I just checked - looks like they're used not in tests, so it's better to declare them as you did.
https://github.com/magento/magento2/search?q=Laminas%5CFilter%5C
https://github.com/magento/magento2/search?q=Laminas%5CHydrator

[ihor-sviziev]

@AndreyChorniy could you add to the description the following line?
Fixes #32442

[AndreyChorniy]

Hello @ihor-sviziev,
I have adjusted the description for this PR.

[ihor-sviziev]

@sivaschenko, for some reason, it didn't link the issue to PR. Could you link it properly?

[sivaschenko]

Hi @ihor-sviziev @AndreyChorniy

The issue is referenced correctly, not sure why github doesn't link it.

@AndreyChorniy have you tried to remove the references for the filter and hydrator dependencies instead of adding them to composer.json?

inputfilter is also referenced:

magento2/setup/src/Zend/Mvc/Controller/LazyControllerAbstractFactory.php

Line 17 in 570a14a

use Laminas\InputFilter\InputFilterPluginManager;

[ihor-sviziev]

Hi @AndreyChorniy,
Thank you for your contribution!
I'm closing this PR as we have a better solution in #32513. It completely removes parts that we did not need, and they used those laminas components. I think it's better to accept it instead.

[m2-assistant]

Hi @AndreyChorniy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.