ImportExport: Fix notice if _attribute_set column is missing #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases, especially when custom import adapters are used, where _attribute_set is not defined in a $row (not for the initial row of course). This is not a problem - but causes a notice.
|
See http://php.net/manual/en/function.isset.php You can use isset($rowData[self::COL_ATTR_SET])instead of isset($rowData[self::COL_ATTR_SET]) && !is_null($rowData[self::COL_ATTR_SET])I think it's should be better |
|
Hello amenk, |
|
+1 for accepting this pull request. I got my system.log constantly trashed with "_attribute_set is not defined" notices. |
magento-team
added a commit
that referenced
this pull request
Apr 7, 2014
* Framework Improvements: * Fixed performance degradation caused by DI argument processors * Modularity improvements: * Introduced the Magento_UrlRewrite module, and moved corresponding classes from Magento_Core to Magento_UrlRewrite * Moved all Install logic to the Magento_Install module * Eliminated the Core\Helper\Js class * Moved the Email related logic from the Magento_Core module to the Magento_Email module * Moved the Cache related logic from the Magento_Core module to library * Indexer improvements: * Added execution time hints for console reindex * Customer Service usage: * Refactored the Magento_Newsletter module to use Customer service layer * Fixed bugs: * Fixed an issue with resetting customer password from the frontend * Fixed an issue where mistakenly the attribute of the Customer Address Edit form was cached * Fixed an issue where admin could not unsubscribe customer on the customer edit page in the backend * Fixed an issue where customers were always subscribed to the newsletter even if not selected during registration * GitHub requests: * [#325] (#325) -- ImportExport: Fix notice if _attribute_set column is missing
|
@amenk, the team has accepted your contribution. We released the fix to the Github. In fact, the issus was fixed a bit earlier, but for some reason we lost the record in the changelog. Thus, we are restoring justice this time :) We are closing this issue. |
magento-team
pushed a commit
that referenced
this pull request
May 29, 2015
[API] Sprint 49 Bugfixes + Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases, especially when custom import adapters are used, where _attribute_set is not defined in a $row (not for the initial row of course). This is not a problem - but causes a notice.