Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[32027][To 2.4-develop] Marked Framework interfaces as API part 4 #32728

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

Usik2203
Copy link
Contributor

Description (*)

This PR fixes #32027

Related Pull Requests

#32170

Fixed Issues (if relevant)

  1. Fixes Mark Framework interfaces as API part 4 #32027>

@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2021

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 13, 2021
@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 13, 2021
@Usik2203
Copy link
Contributor Author

@magento run all tests

@danielrussob
Copy link

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

@aleron75
Copy link
Contributor

I confirm the PR covers all the changes requested in the related Issue. Waiting for tests to finish in order to approve.

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests EE, WebAPI Tests

@Usik2203
Copy link
Contributor Author

Hi @aleron75
Thank you for review
Could i kindly ask you to remove Cleanup label based on this comment
#32735 (comment)
Thanks!

@danielrussob
Copy link

As mentioned with Sergii Ivashchenko static tests are ok

@gabrieldagama
Copy link
Contributor

@magento-engcom-team
Copy link
Contributor

@gabrieldagama, an error occurred during the Pull Request import.

1 similar comment
@magento-engcom-team
Copy link
Contributor

@gabrieldagama, an error occurred during the Pull Request import.

@gabrieldagama
Copy link
Contributor

@magento-engcom-team
Copy link
Contributor

@gabrieldagama the branch with code successfully imported intomagento-engcom/magento2ce repository. Branch name: imported-magento-magento2-32728.

@magento-cicd2 magento-cicd2 merged commit 20dfc93 into magento:api-changes-develop Apr 22, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 22, 2021

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Encryption Component: Event Component: Exception Component: Filesystem Component: Filter Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Project: API Changes Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark Framework interfaces as API part 4
6 participants