Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[32029][To 2.4-develop] Mark Framework interfaces as API part 5 #32729

Merged
merged 2 commits into from
Apr 22, 2021
Merged

[32029][To 2.4-develop] Mark Framework interfaces as API part 5 #32729

merged 2 commits into from
Apr 22, 2021

Conversation

Usik2203
Copy link
Contributor

Description (*)

This PR fixes #32029

Related Pull Requests

#32168

Fixed Issues (if relevant)

  1. Fixes magento/magento2 Mark Framework interfaces as API part 5 #32029>

@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2021

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 13, 2021
@Usik2203
Copy link
Contributor Author

@magento run all tests

@gabrieldagama gabrieldagama mentioned this pull request Apr 13, 2021
Closed
4 tasks
@gabrieldagama gabrieldagama changed the base branch from 2.4-develop to api-changes-develop April 13, 2021 13:12
@danielrussob danielrussob self-assigned this Apr 13, 2021
@danielrussob
Copy link

@magento run Functional Tests B2B

@danielrussob
Copy link

I confirm that this PR is just a code cleanup / marked as API some class. We are waiting for tests.

@danielrussob
Copy link

I confirm that all files mentioned in issue (#32029) are covered

@danielrussob
Copy link

Hi @Usik2203 , thank you for your contribution

Can you tell me why you have marked:

lib/internal/Magento/Framework/HTTP/AsyncClient/Request.php
lib/internal/Magento/Framework/HTTP/AsyncClient/Response.php
lib/internal/Magento/Framework/Image/Adapter/AbstractAdapter.php
lib/internal/Magento/Framework/Mail/Address.php
lib/internal/Magento/Framework/ObjectManager/ConfigCacheInterface.php
lib/internal/Magento/Framework/ObjectManager/RelationsInterface.php as API?

It's not linked in: #32029

@Usik2203
Copy link
Contributor Author

Hi @Usik2203 , thank you for your contribution

Can you tell me why you have marked:

lib/internal/Magento/Framework/HTTP/AsyncClient/Request.php
lib/internal/Magento/Framework/HTTP/AsyncClient/Response.php
lib/internal/Magento/Framework/Image/Adapter/AbstractAdapter.php
lib/internal/Magento/Framework/Mail/Address.php
lib/internal/Magento/Framework/ObjectManager/ConfigCacheInterface.php
lib/internal/Magento/Framework/ObjectManager/RelationsInterface.php as API?

It's not linked in: #32029

Hi @danielrussob @aleron75
These classes were marked for preventing such type of failed static tests
#32175 (comment)

Also could i kindly ask you to remove Cleanup label based on this comment
#32735 (comment)

Thanks!

@aleron75 aleron75 removed the Cleanup label Apr 14, 2021
@gabrieldagama
Copy link
Contributor

@magento import code to https://github.com/magento-engcom/magento2ce

@magento-engcom-team
Copy link
Contributor

@gabrieldagama, an error occurred during the Pull Request import.

2 similar comments
@magento-engcom-team
Copy link
Contributor

@gabrieldagama, an error occurred during the Pull Request import.

@magento-engcom-team
Copy link
Contributor

@gabrieldagama, an error occurred during the Pull Request import.

@gabrieldagama
Copy link
Contributor

@magento import code to https://github.com/magento-engcom/magento2ce

@magento-engcom-team
Copy link
Contributor

@gabrieldagama, an error occurred during the Pull Request import.

1 similar comment
@magento-engcom-team
Copy link
Contributor

@gabrieldagama, an error occurred during the Pull Request import.

@gabrieldagama
Copy link
Contributor

@magento import code to https://github.com/magento-engcom/magento2ce

@magento-engcom-team
Copy link
Contributor

@gabrieldagama, an error occurred during the Pull Request import.

1 similar comment
@magento-engcom-team
Copy link
Contributor

@gabrieldagama, an error occurred during the Pull Request import.

@gabrieldagama
Copy link
Contributor

@magento import code to https://github.com/magento-engcom/magento2ce

@magento-engcom-team
Copy link
Contributor

@gabrieldagama the branch with code successfully imported intomagento-engcom/magento2ce repository. Branch name: imported-magento-magento2-32729.

@magento-cicd2 magento-cicd2 merged commit 55819d2 into magento:api-changes-develop Apr 22, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 22, 2021

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrussob danielrussob danielrussob approved these changes

@aleron75 aleron75 Awaiting requested review from aleron75

Assignees

@aleron75 aleron75

@danielrussob danielrussob

Labels
Component: HTTP Component: Image Component: Indexer Component: Interception Component: Locale Component: Mail Component: Message Component: ObjectManager Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Project: API Changes Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark Framework interfaces as API part 5
6 participants
@Usik2203 @danielrussob @gabrieldagama @magento-engcom-team @aleron75 @magento-cicd2