Magento 2.3 contact form not sending emails( No log entry). #32730

engcom-Kilo · 2021-04-13T11:01:17Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Magento 2.3 contact form not sending emails( No log entry) #23645

Manual testing scenarios (*)

see Magento 2.3 contact form not sending emails( No log entry) #23645

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-04-13T11:01:19Z

Hi @engcom-Kilo. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Kilo · 2021-04-13T11:02:50Z

@magento run all tests

ihor-sviziev · 2021-04-13T14:05:48Z

Looks good to me. Let's wait for test results
@magento run all tests

magento-engcom-team · 2021-04-14T06:03:57Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9000 has been created to process this Pull Request

dmitriyprime · 2021-04-15T09:57:14Z

✔️ QA passed

dmitriyprime · 2021-04-15T10:02:41Z

After fix:

ihor-sviziev

Hey @dmitriyprime @engcom-Kilo ,
It looks like that's not OK that an exception was thrown there and a customer came to the report page. It wasn't expected. The correct behavior should be exception logged to var/exception.log or var/system.log file

zakdma · 2021-04-21T10:31:17Z

@magento import code to https://github.com/magento-tsg/magento2ce

magento-engcom-team · 2021-04-21T10:34:04Z

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-32730.

m2-assistant · 2021-04-22T04:39:52Z

Hi @engcom-Kilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ihor-sviziev · 2021-04-22T07:15:30Z

app/code/Magento/Email/Model/Transport.php

@@ -100,7 +110,8 @@ public function sendMessage()

            $this->laminasTransport->send($laminasMessage);
        } catch (\Exception $e) {
-            throw new MailException(new Phrase($e->getMessage()), $e);
+            $this->logger->error($e);
+            throw new MailException(new Phrase('Unable to send mail. Please try again later.'));


@engcom-Kilo @zakdma, we have regression here. The original exception should be passed as a 2nd param here to understand why it failed, as it was in the past.

FYI here is a PR that fixes this regression #33419

tuyennn · 2021-06-16T10:37:37Z

@ihor-sviziev This is completely useless pull request. With

throw new MailException(new Phrase($e->getMessage()), $e);

we already knew what the exception was.

ihor-sviziev · 2021-07-05T10:10:07Z

@tuyennn, before this PR, we hadn't any log record about email sending failure.

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Apr 13, 2021

magento-engcom-team added Component: Contact Release Line: 2.4 labels Apr 13, 2021

m2-community-project bot added the Progress: pending review label Apr 13, 2021

engcom-Kilo force-pushed the MC-18023 branch from f765273 to cd766d1 Compare April 13, 2021 11:02

ihor-sviziev self-assigned this Apr 13, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Apr 13, 2021

ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Progress: pending review and removed Progress: review labels Apr 13, 2021

m2-community-project bot removed the Progress: pending review label Apr 13, 2021

ihor-sviziev added Progress: pending review Progress: review labels Apr 13, 2021

m2-community-project bot added Progress: pending review Progress: review and removed Progress: review Progress: pending review labels Apr 13, 2021

ihor-sviziev removed the Progress: pending review label Apr 13, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Apr 13, 2021

ihor-sviziev approved these changes Apr 14, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Apr 14, 2021

magento-engcom-team added Component: Email Component: Mail and removed Component: Contact labels Apr 14, 2021

zakdma approved these changes Apr 15, 2021

View reviewed changes

ihor-sviziev requested changes Apr 16, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Apr 16, 2021

magento-engcom-team merged commit 78ec76a into magento:2.4-develop Apr 22, 2021

ihor-sviziev reviewed Apr 22, 2021

View reviewed changes

m2-community-project bot removed the Progress: needs update label Apr 22, 2021

This was referenced Jul 5, 2021

Fix regression - Add previous exception with more details magento-tsg/magento2#4

Closed

Fix regression - Add previous exception with more details #33419

Merged

m2-assistant bot mentioned this pull request Sep 27, 2021

[Issue] Fix regression - Add previous exception with more details #34166

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Magento 2.3 contact form not sending emails( No log entry). #32730

Magento 2.3 contact form not sending emails( No log entry). #32730

engcom-Kilo commented Apr 13, 2021

m2-assistant bot commented Apr 13, 2021

engcom-Kilo commented Apr 13, 2021

ihor-sviziev commented Apr 13, 2021 •

edited

Loading

magento-engcom-team commented Apr 14, 2021

dmitriyprime commented Apr 15, 2021

dmitriyprime commented Apr 15, 2021 •

edited

Loading

ihor-sviziev left a comment •

edited

Loading

zakdma commented Apr 21, 2021

magento-engcom-team commented Apr 21, 2021

m2-assistant bot commented Apr 22, 2021

ihor-sviziev Apr 22, 2021

ihor-sviziev Jul 5, 2021

tuyennn commented Jun 16, 2021

ihor-sviziev commented Jul 5, 2021

Magento 2.3 contact form not sending emails( No log entry). #32730

Magento 2.3 contact form not sending emails( No log entry). #32730

Conversation

engcom-Kilo commented Apr 13, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Apr 13, 2021

engcom-Kilo commented Apr 13, 2021

ihor-sviziev commented Apr 13, 2021 • edited Loading

magento-engcom-team commented Apr 14, 2021

dmitriyprime commented Apr 15, 2021

dmitriyprime commented Apr 15, 2021 • edited Loading

ihor-sviziev left a comment • edited Loading

Choose a reason for hiding this comment

zakdma commented Apr 21, 2021

magento-engcom-team commented Apr 21, 2021

m2-assistant bot commented Apr 22, 2021

ihor-sviziev Apr 22, 2021

Choose a reason for hiding this comment

ihor-sviziev Jul 5, 2021

Choose a reason for hiding this comment

tuyennn commented Jun 16, 2021

ihor-sviziev commented Jul 5, 2021

ihor-sviziev commented Apr 13, 2021 •

edited

Loading

dmitriyprime commented Apr 15, 2021 •

edited

Loading

ihor-sviziev left a comment •

edited

Loading