-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Load resizable jquery-ui chunk for knockout resizable binding only when actually used #32756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load resizable jquery-ui chunk for knockout resizable binding only when actually used #32756
Conversation
Hi @martasiewierska. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Looks good to me. Let's wait for test results. |
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE |
@mrtuvn, I believe it would be too hard to cover these changes with any test. I prefer not to cover it. What do you think? |
app/code/Magento/Ui/view/base/web/js/lib/knockout/bindings/resizable.js
Outdated
Show resolved
Hide resolved
…izable.js Co-authored-by: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests EE, Integration Tests, WebAPI Tests |
@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests |
@magento run Functional Tests B2B, Functional Tests EE |
✔️ QA passed |
Moving this PR back to "accept" status... It looks like it was moved due to some mistake |
…nding only when actually used #32756
Hi @martasiewierska, thank you for your contribution! |
Description (*)
Resizable knockout binding is hardly never used on the frontend, it also does not work there (see #32753) As we are constantly often struggling to reduce unused javascript and improve performance metrics for our shops I would like to add this small step to remove not used javascript.
Manual testing scenarios (*)
Questions or comments
Fixed Issues (if relevant)
Contribution checklist (*)