Skip to content

Load resizable jquery-ui chunk for knockout resizable binding only when actually used #32756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

martasiewierska
Copy link
Contributor

@martasiewierska martasiewierska commented Apr 15, 2021

Description (*)

Resizable knockout binding is hardly never used on the frontend, it also does not work there (see #32753) As we are constantly often struggling to reduce unused javascript and improve performance metrics for our shops I would like to add this small step to remove not used javascript.

Manual testing scenarios (*)

  1. Create empty page without any other component that require jquery/ui-modules/resizable.js
  2. Check if jquery/ui-modules/resizable.js file is not loaded in Network tab (no js bundling)
  3. Create test UIComponent with resizable knockout binding
  4. Check if jquery/ui-modules/resizable.js file is loaded in Network tab (no js bundling)

Questions or comments

Fixed Issues (if relevant)

  1. Fixes Resizable knockout binding does not work on the frontend #32753

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2021

Hi @martasiewierska. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ptylek
Copy link
Contributor

ptylek commented Apr 15, 2021

Looks good to me. Let's wait for test results.
@magento run all tests

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 15, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Apr 15, 2021

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@mrtuvn mrtuvn added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix labels Apr 15, 2021
@ihor-sviziev
Copy link
Contributor

@mrtuvn, I believe it would be too hard to cover these changes with any test. I prefer not to cover it. What do you think?

…izable.js

Co-authored-by: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests, WebAPI Tests

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Apr 16, 2021
@ptylek
Copy link
Contributor

ptylek commented Apr 17, 2021

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@ihor-sviziev ihor-sviziev added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Apr 19, 2021
@dmitriyprime
Copy link
Contributor

✔️ QA passed

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented May 5, 2021

Moving this PR back to "accept" status... It looks like it was moved due to some mistake

@m2-assistant
Copy link

m2-assistant bot commented Jun 25, 2021

Hi @martasiewierska, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Area: Perf/Frontend All tickets related with improving frontend performance. Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Ui improvement Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizable knockout binding does not work on the frontend
7 participants