Update underscore to latest version #33609

mrtuvn · 2021-07-28T02:54:48Z

Description (*)

Updated to 1.13.1 version (UMD exports) April 15, 2021
https://underscorejs.org/underscore-umd.js
https://underscorejs.org/underscore-umd-min.js (minified)
This version included patch GHSA-cf4h-3jhx-xvhq security vulnerabilities
Previously used 1.8.2 (2015)

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/583

Fixed Issues (if relevant)

Fixes Investigate upgrade to the latest underscorejs/create POC #32850

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-07-28T02:54:50Z

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mrtuvn · 2021-07-28T05:52:30Z

@magento run all tests

magento-automated-testing · 2021-07-28T05:52:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik

@mrtuvn Thanks for PR. Please check failed js tests

andrewbess

Hello @mrtuvn
Thank you for your contribution.
Could you please check failed tests and fix problems.
Thank you in advance

mrtuvn · 2021-07-28T19:16:34Z

@magento run Unit Tests, Integration Tests, Functional Tests CE, Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-07-28T19:16:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-07-31T05:19:43Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-07-31T05:19:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-08-02T03:50:57Z

@magento run all tests

magento-automated-testing · 2021-08-02T03:51:04Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-08-02T08:29:18Z

@magento run Integration Tests, Functional Tests CE

magento-automated-testing · 2021-08-02T08:29:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-08-02T18:10:47Z

@magento run Functional Tests CE

magento-automated-testing · 2021-08-02T18:10:54Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-08-11T10:38:42Z

@magento give me test instance with edition ee

magento-deployment-service · 2021-08-11T10:38:46Z

Hi @eduard13. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-08-11T10:44:20Z

Hi @eduard13, here is your Magento Instance: https://41a30c4e183a131637c007657beb41d9.instances.magento-community.engineering
Admin access: https://41a30c4e183a131637c007657beb41d9.instances.magento-community.engineering/admin_ac42
Login: 9be7c46e
Password: 19cb86d7f15f

magento-automated-testing · 2021-08-11T11:08:39Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-11T11:46:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-11T13:45:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-11T18:54:00Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-08-12T03:17:14Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-08-12T03:17:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-08-12T05:04:53Z

@magento run Database Compare, Integration Tests, Magento Health Index, Sample Data Tests B2B, Sample Data Tests EE, Sample Data Tests CE, Semantic Version Checker, Static Tests, Unit Tests, WebAPI Tests

magento-automated-testing · 2021-08-12T05:04:59Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-08-12T06:28:48Z

@magento run all tests

magento-automated-testing · 2021-08-12T06:28:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-08-12T08:56:09Z

@magento run all tests

magento-automated-testing · 2021-08-12T08:57:39Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev

✔ Approved

Failing integration tests looks not related to changes form this PR.

mrtuvn · 2021-08-13T14:25:21Z

@magento run Integration Tests

magento-automated-testing · 2021-08-13T14:25:26Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-16T09:19:30Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-17T06:12:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

m2-assistant · 2021-08-17T11:11:47Z

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

mrtuvn added the Project: Platform Health label Jul 28, 2021

m2-community-project bot added the Progress: pending review label Jul 28, 2021

ihor-sviziev self-assigned this Jul 28, 2021

m2-community-project bot removed the Progress: pending review label Jul 28, 2021

ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 28, 2021

m2-community-project bot added the Progress: review label Jul 28, 2021

ihor-sviziev added the Progress: pending review label Jul 28, 2021

m2-community-project bot removed the Progress: pending review label Jul 28, 2021

ihor-sviziev added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 28, 2021

ihor-sviziev mentioned this pull request Jul 28, 2021

Investigate upgrade to the latest underscorejs/create POC #32850

Closed

Den4ik self-requested a review July 28, 2021 08:58

Den4ik self-assigned this Jul 28, 2021

Den4ik requested changes Jul 28, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jul 28, 2021

andrewbess requested changes Jul 28, 2021

View reviewed changes

m2-community-project bot assigned andrewbess Jul 28, 2021

Update underscore

6c34c9d

Fixing JSCS

2c52a3c

ihor-sviziev approved these changes Aug 12, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Aug 12, 2021

mrtuvn removed the help wanted label Aug 12, 2021

andrewbess approved these changes Aug 17, 2021

View reviewed changes

andrewbess merged commit a4dee84 into magento:platform-health Aug 17, 2021

andrewbess added Award: category of expertise Award: special achievement labels Aug 17, 2021

Update underscore to latest version #33609

Update underscore to latest version #33609

Uh oh!

Conversation

mrtuvn commented Jul 28, 2021 • edited by eduard13 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jul 28, 2021

Uh oh!

mrtuvn commented Jul 28, 2021

Uh oh!

magento-automated-testing bot commented Jul 28, 2021

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

andrewbess left a comment

Choose a reason for hiding this comment

Uh oh!

mrtuvn commented Jul 28, 2021

Uh oh!

magento-automated-testing bot commented Jul 28, 2021

Uh oh!

mrtuvn commented Jul 31, 2021

Uh oh!

magento-automated-testing bot commented Jul 31, 2021

Uh oh!

mrtuvn commented Aug 2, 2021

Uh oh!

magento-automated-testing bot commented Aug 2, 2021

Uh oh!

mrtuvn commented Aug 2, 2021

Uh oh!

magento-automated-testing bot commented Aug 2, 2021

Uh oh!

mrtuvn commented Aug 2, 2021

Uh oh!

magento-automated-testing bot commented Aug 2, 2021

Uh oh!

eduard13 commented Aug 11, 2021

Uh oh!

magento-deployment-service bot commented Aug 11, 2021

Uh oh!

magento-deployment-service bot commented Aug 11, 2021

Uh oh!

magento-automated-testing bot commented Aug 11, 2021

Uh oh!

magento-automated-testing bot commented Aug 11, 2021

Uh oh!

magento-automated-testing bot commented Aug 11, 2021

Uh oh!

magento-automated-testing bot commented Aug 11, 2021

Uh oh!

mrtuvn commented Aug 12, 2021

Uh oh!

magento-automated-testing bot commented Aug 12, 2021

Uh oh!

eduard13 commented Aug 12, 2021

Uh oh!

magento-automated-testing bot commented Aug 12, 2021

Uh oh!

eduard13 commented Aug 12, 2021

Uh oh!

magento-automated-testing bot commented Aug 12, 2021

Uh oh!

eduard13 commented Aug 12, 2021

Uh oh!

magento-automated-testing bot commented Aug 12, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

mrtuvn commented Aug 13, 2021

Uh oh!

mrtuvn commented Jul 28, 2021 •

edited by eduard13

Loading