Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting 'cahce' typo in documentation. #339

Closed
wants to merge 2 commits into from
Closed

Correcting 'cahce' typo in documentation. #339

wants to merge 2 commits into from

Conversation

parhamr
Copy link

@parhamr parhamr commented Aug 21, 2013

As titled.

@verklov
Copy link
Contributor

verklov commented Nov 7, 2013

Hello parhamr,
Sorry for the delay with the response.
Thank you for your contribution! Your reported issue is now only partly reproducible due to the changes we made to the Magento 2 product. We are planning to include the valid part of your pull request in a future Magento 2 code release.

magento-team added a commit that referenced this pull request Nov 22, 2013
* Moved general action-related functionality to \Magento\App\Action\Action in the library. Removed Magento\Core\Controller\Varien\Action and related logic from the Magento_Core module
* Moved view-related methods from action interface to \Magento\App\ViewInterface with corresponding implementation
* Moved redirect creation logic from the action interface to \Magento\App\Response\RedirectInterface
* Moved Magento\Core common blocks to the library
* Added reading of etc/integration/config.xml and etc/integration/api.xml files for API Integrations
* Various improvements:
  * Email-related logic from the Core and Adminhtml modules consolidated in the new Email module
* GitHub requests:
  * [#238](#238) -- Improve escaping HTML entities in URL
  * [#199](#199) -- Replaced function calls to array_push with adding the elements directly
  * [#182](#182) -- By default use collection _idFieldName for toOption* methods.
  * [#233](#233) -- Google Rich Snippet Code
  * [#339](#339) -- Correcting 'cahce' typo in documentation.
  * [#232](#232) -- Update app/code/core/Mage/Checkout/controllers/CartController.php (fix issue #27632)
* Fixed bugs:
  * Fixed JavaScript error when printing orders from the frontend
  * Fixed Captcha problems on various forms when Captcha is enabled on the frontend
  * Fixed "Page not found" on category page if setting "Add Store Code to Urls" to "Yes" in the backend config
  * Fixed Fatal error when creating shipping label for returns
@verklov
Copy link
Contributor

verklov commented Nov 25, 2013

Hello parhamr,
We have processed your pull request. The code should be available in version dev53 released last Friday.

Thank you for your contribution!

@verklov verklov closed this Nov 25, 2013
@parhamr
Copy link
Author

parhamr commented Nov 27, 2013

@mage2-team cheers!

magento-team pushed a commit that referenced this pull request Jun 5, 2015
[Vanilla] Bugfixes + Modal Window Widget
magento-team pushed a commit that referenced this pull request Feb 3, 2016
magento-engcom-team added a commit that referenced this pull request Feb 15, 2019
 - Merge Pull Request magento/graphql-ce#339 from pmclain/graphql-ce:feature/shipping-rates
 - Merged commits:
   1. 5b7b239
   2. 6d6d5d5
   3. 242cd2f
   4. 2fa4f1f
   5. 506b9d2
   6. 5ef26f7
magento-engcom-team pushed a commit that referenced this pull request Nov 3, 2021
AC-117: Synchronous XMLHttpRequest warning message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants