34084: Replaced tag 'br' to a valid version

[AZiniukhin]

Description (*)

Deprecated "<br>" and "</br>" tags were changed to their valid version "<br />"

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Replace </br> with a valid version of <br /> #34084

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @AZiniukhin. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@xmav, I guess this change is related to the jquery update. Could you check it?

[BarnyShergold]

@magento run all tests

[magento-automated-testing]

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

[xmav]

Hi @ihor-sviziev
yes, jQuery require tags to be properly closed. It is important to have "correct" tags in html that will be manipulated by jquery. From that point it is not needed to update tags in translations like Warning!<br />This action will remove this user from already assigned role.<br />Are you sure? as this should not affect jquery but will be backward incompatible

[BarnyShergold]

@magento run all tests

[magento-automated-testing]

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

[BarnyShergold]

@xmav - Can you fix the conflicting file please and check tests will run - they won't at the moment as you can see.

[xmav]

@BarnyShergold I believe this should be addressed by @AZiniukhin

[hostep]

Maybe take the following comment into account as well? Or are there valid cases for keeping a space in the tag in the year 2021?

[orlangur]

Please use a shorter tag version as suggested in #34136 (comment)

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

[DanielRuf]

Magento 2 uses html5 as doctype so this makes no real difference afaik.

Where is documented, that <br> does not work for jQuery? Because this is the valid version for empty elements in html5, <br/> would be xhtml.

[DanielRuf]

I did not find any depreciation notice at https://www.w3.org/TR/2011/WD-html5-author-20110809/the-br-element.html

See also https://stackoverflow.com/questions/1946426/html-5-is-it-br-br-or-br

[BarnyShergold]

@BarnyShergold I believe this should be addressed by @AZiniukhin

Yes - sorry, wrong tag entered!

[orlangur]

@DanielRuf ok :) We have too many <br /> with or without space currently in code but without enforcing only one variant let's not touch them.

[orlangur]

@AZiniukhin as pointed out in discussion <br> is perfectly valid so don't touch them.

Just change all </br> to <br>.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

[Den4ik]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[BarnyShergold]

@magento run functional tests CE,Integration Tests,Static Tests,Unit Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[BarnyShergold]

@magento run functional tests CE,Integration Tests,Static Tests,Unit Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[orlangur]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[AZiniukhin]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Dash]

Hello @AZiniukhin ,

Thank you for your contributions!

Please resolve the conflict so we can proceed with this PR.

Thanks again!

[engcom-Dash]

Closing this PR since it has not been updated in a while. Please feel free to reopen if needed.