[WIP] Fixes some wrong usages of ignoring coding standards in less files. #38012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
New Magento coding standards v32 came with fix for ignoring underscore usage in less files, I tried looking to remove some of the ignores that got added in less files over the last couple of months that ran into this false positive.
However, while trying to remove those now obsolete ignores, I ran into a bunch more problems, where I discovered that the syntax
//@codingStandardsIgnoreEnd
wasn't even working, it should have been used as/* @codingStandardsIgnoreEnd */
.While fixing those, ran into a bunch more problems, like:
:first-child
and similar ones, solved that by using 2 colons (::first-child
), which is considered the way of the future, but it might also be considered a bug in coding standards?.I'm considering this WIP, still TODO:
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)