Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magento/Core] Fixed typos #382

Closed
wants to merge 1 commit into from
Closed

Conversation

pborreli
Copy link

@pborreli pborreli commented Oct 5, 2013

No description provided.

@davidalger
Copy link
Member

Sure you got 'em all? ;)

@pborreli
Copy link
Author

pborreli commented Oct 8, 2013

fixed few typos from Magento/Core, all of them ? not sure, but if you find some more, don't hesitate :)

@@ -151,8 +151,8 @@ public function addRequestParam($url, $param)
public function removeRequestParam($url, $paramKey, $caseSensitive = false)
{
$regExpression = '/\\?[^#]*?(' . preg_quote($paramKey, '/') . '\\=[^#&]*&?)/' . ($caseSensitive ? '' : 'i');
while (preg_match($regExpression, $url, $mathes) != 0) {
$paramString = $mathes[1];
while (preg_match($regExpression, $url, $matches) != 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always use deep equals!

preg_match() returns 1 if the pattern matches given subject, 0 if it does not, or FALSE if an error occurred.

@verklov
Copy link
Contributor

verklov commented Oct 21, 2013

Hi pborreli and SchumacherFM!
Thank you for your contribution! We have opened internal ticket in our bug tracker. We will post the update once we fix the issues you pointed at.

magento-team added a commit that referenced this pull request Nov 29, 2013
* Modularity improvements:
  * Breakdown of the Adminhtml module:
     * Moved Newsletter, Report logic to the respective modules
     * Moved blocks, config, view, layout files of other components from Adminhtml folder to respective modules
  * Removed application dependencies from the library
* Move Magento\Core common blocks in the library
* Application areas rework:
  * Areas are independent from Store
  * Removed deprecated annotation from the getArea methods
* GitHub requests:
  * [#245](#245) -- Resolve design flaws in core URL helper
  * [#247](#247) -- Bug in Mage_Page_Block_Html_Header->getIsHomePage
  * [#259](#259) -- Turkish Lira (TRY) is supported for Turkish members.
  * [#262](#262) -- Update Rule.php
  * [#373](#373) -- [Magento/Sales] Fixed typos
  * [#382](#382) -- [Magento/Core] Fixed typos
  * [#304](#304) -- Removed Erroneous closing "
  * [#323](#323) -- InstanceController.php - made setBody protected
  * [#349](#349) -- Move Mage_Catalog menu declaration into Mage_Catalog module.
  * [#265](#265) -- Update Merge.php
  * [#271](#271) -- Check Data should validate gallery information
  * [#305](#305) -- Extra ", tidied up nested quotes
  * [#352](#352) -- Add Croatia Country as part of European Union since 1st July 2013 for default european local countries in configuration
  * [#224](#224) -- Tax formatting is locale aware and should not
  * [#338](#338) -- Correcting SQL for required_options column
  * [#327](#327) -- cart api bug fix & partial invoice credit memo divide by zero warning
* Themes update:
  * Old frontend (magento_demo) and backend (magento_basic) themes are removed
  * Updated templates and layout updates in the Bundle, Catalog, CatalogInventory, CatalogSearch, Downloadable, ProductAlert, Reports, Sendfriend modules
* Fixed bugs:
  * Fixed the error when  Magento cannot be reinstalled to the same database with table prefix
  * Fixed report Products in Cart
  * Fixed error on attempt to insert image to CMS pages under version control
  * Fixed order status grid so that you can assign state, edit, and view custom order status
  * Fixed Related Products Rule page so that category can be selected on conditions tab
  * Fixed Magento_Paypal_Controller_ExpressTest integration test so it is re-enabled
  * Fixed the bug with international DHL quotes
@verklov
Copy link
Contributor

verklov commented Nov 29, 2013

Hello pborreli and SchumacherFM,
We have processed your pull request. The code is released in version dev54.

@verklov verklov closed this Nov 29, 2013
vpelipenko pushed a commit that referenced this pull request Jun 26, 2015
[WD] Update Content in Magento2 + Bugs
okorshenko pushed a commit that referenced this pull request Mar 3, 2016
[SUPPORT] MDVA-13: Paypal via Braintree button in the minicart – another button appears whenever a product is added to the cart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants