Skip to content

#38682 - Fix DeployPackage type error #38683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024
Merged

#38682 - Fix DeployPackage type error #38683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/code/Magento/Deploy/Service/DeployPackage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,13 @@ public function deployEmulated(Package $package, array $options, $skipLogging =
try {
$this->processFile($file, $package);
} catch (ContentProcessorException $exception) {
$errorMessage = __('Compilation from source: ')
. $file->getSourcePath()
. PHP_EOL . $exception->getMessage() . PHP_EOL;
$errorMessage = __(
'Compilation from source: %1',
$file->getSourcePath()
. PHP_EOL
. $exception->getMessage()
. PHP_EOL
);
$this->errorsCount++;
$this->logger->critical($errorMessage);
$package->deleteFile($file->getFileId());
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Deploy/i18n/en_US.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"The configuration file has changed. Run app:config:import or setup:upgrade command to synchronize configuration.","The configuration file has changed. Run app:config:import or setup:upgrade command to synchronize configuration."
"Wrong type specified: '%1'","Wrong type specified: '%1'"
"Wrong queue type specified.","Wrong queue type specified."
"Compilation from source: ","Compilation from source: "
"Compilation from source: %1","Compilation from source: %1"
"Wrong deploy strategy type: %1","Wrong deploy strategy type: %1"
"Some error","Some error"
"some message","some message"