Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to define Area for dev:di:info CLI command #38758 #38759

Merged
merged 19 commits into from
Oct 18, 2024
Merged

Ability to define Area for dev:di:info CLI command #38758 #38759

merged 19 commits into from
Oct 18, 2024

Conversation

rostilos
Copy link
Contributor

@rostilos rostilos commented May 26, 2024 •
edited
Loading

Description (*)

PR that adds the ability to specify in php bin/magento dev:di:info <class> <area> command the desired area code.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Ability to define Area for dev:di:info CLI command #38758

Manual testing scenarios (*)

  1. Run php bin/magento dev:di:info <class> <area>
  2. In the console you can see information about di for the selected class under a given scope ( standard GLOBAL + defined in the command parameters )

Questions or comments

Example:
app/code/Magento/Backend/etc/adminhtml/di.xml
2024-05-26_05-21

Note : on the current 2.4. branch, an error will occur when outputting information. It is not related to the current task, see : #38740

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented May 26, 2024

Hi @rostilos. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Perspective Team partners-contribution Pull Request is created by Magento Partner labels May 26, 2024
@engcom-Charlie engcom-Charlie added the Priority: P3 May be fixed according to the position in the backlog. label May 28, 2024
@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jun 6, 2024
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Jul 17, 2024
@engcom-Hotel engcom-Hotel removed the Priority: P3 May be fixed according to the position in the backlog. label Jul 18, 2024
engcom-Hotel
engcom-Hotel requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rostilos,

Thanks for the contribution!

Please resolve the conflicts to process this PR further.

Thanks

@engcom-Charlie engcom-Charlie self-assigned this Jul 18, 2024
@engcom-Charlie engcom-Charlie added Priority: P3 May be fixed according to the position in the backlog. and removed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Jul 18, 2024
@engcom-Charlie
Copy link
Contributor

Hi @rostilos,

Thank you for your contribution!

Please resolve the conflicts in order to proceed further on this PR. Till then closing this PR. Once done feel free to reopen or let us know.

Thank you!

Merge remote-tracking branch 'refs/remotes/origin/2.4-develop' into f…
2553d94 
…ix-for-issue-38758

# Conflicts:
#	app/code/Magento/Developer/Console/Command/DiInfoCommand.php
@rostilos
Copy link
Contributor Author

Hi @rostilos,

Thank you for your contribution!

Please resolve the conflicts in order to proceed further on this PR. Till then closing this PR. Once done feel free to reopen or let us know.

Thank you!

@engcom-Charlie Hi! I'd like to reopen the PR, and add appropriate edits on conflict resolution

@rostilos
Copy link
Contributor Author

rostilos commented Sep 4, 2024

@engcom-Hotel please check it ( also added integration tests )

@engcom-Hotel
Copy link
Contributor

@magento run all tests

engcom-Hotel
engcom-Hotel requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rostilos,

Thanks for making the changes!

Now the changes seems good to me except the one below. Please correct the same and also look into the failed tests.

Thanks

dev/tests/integration/testsuite/Magento/Developer/Console/Command/DiInfoCommandTest.php Show resolved Hide resolved
@rostilos
Copy link
Contributor Author

@magento run all tests

@rostilos
Copy link
Contributor Author

rostilos commented Sep 11, 2024 •
edited
Loading

@engcom-Hotel Made the requested edits and also corrected the errors concerning codestyle. Failed functional tests seems flaky to me

@engcom-Bravo
Copy link
Contributor

@magento run all tests

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Sep 12, 2024
@engcom-Bravo
Copy link
Contributor

Hi @rostilos,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Run php bin/magento dev:di:info
  • In the console you can see information about di for the selected class under a given scope ( standard GLOBAL + defined in the command parameters )

Before: ✖️ 

Screenshot 2024-09-12 at 13 00 49

After: ✔️

Screenshot 2024-09-12 at 13 00 59

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Integration Tests

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Sep 13, 2024 •
edited
Loading

One of the Functional B2B test failures in recent 2 builds is not constant and remaining one is a known issue. Hence moving the PR to Merge in Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38759/bab2e8630a660e333f7c876842e29c14/Functional/allure-report-b2b/index.html

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38759/32dca44fb17cbbdb8e9c9d55883d4d4d/Functional/allure-report-b2b/index.html

Known issue :
StorefrontPrintListItemsFromRequisitionListTest: #AC-12166

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit f1c890f into magento:2.4-develop Oct 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Charlie engcom-Charlie

@engcom-Hotel engcom-Hotel

Labels
Partner: Perspective Team partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to define Area for dev:di:info CLI command
7 participants
@rostilos @engcom-Charlie @engcom-Hotel @engcom-Bravo @sinhaparul @magento-devops-reposync-svc @m2-github-services