Skip to content

Exception #0 (ReflectionException) issue fixed #39819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

Exception #0 (ReflectionException) issue fixed #39819

wants to merge 2 commits into from

Conversation

Sathakathulla-S
Copy link

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Exception #0 (ReflectionException): Class "***********************" does not exist. Wrong logic. #38480

Manual testing scenarios (*)

  1. Creating a custom product attribute programmatically with dropdown type.
  2. Don't create a source class for the attribute.
  3. Try to open a product in admin panel.
  4. ReflectionException is thrown.

Exception result

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 15, 2025

Hi @Sathakathulla-S. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@Sathakathulla-S
Copy link
Author

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 22, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Apr 22, 2025
@engcom-Charlie engcom-Charlie added the Project: Community Picked PRs upvoted by the community label May 13, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label May 14, 2025
engcom-Hotel
engcom-Hotel requested changes May 14, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Sathakathulla-S,

Thank you for the contribution!

Please sign the CLA and fix the failed static tests. Also please refer to the below review comments.

Thanks

app/code/Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php
try {
$source = $this->_universalFactory->create($this->_source);
} catch (\ReflectionException $e) {
$source = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using false, consider returning null to indicate the absence of a valid source object.

app/code/Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php
@@ -636,7 +636,11 @@ public function getSource()
} else {
$this->_source = $this->getSourceModel();
}
$source = $this->_universalFactory->create($this->_source);
try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the try-catch block for better readability.

@engcom-Hotel engcom-Hotel moved this from Pending Review to Changes Requested in Community Dashboard May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

Assignees
No one assigned
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Progress: pending review Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Community Dashboard
Status: Changes Requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception #0 (ReflectionException): Class "***********************" does not exist. Wrong logic.
4 participants
@Sathakathulla-S @engcom-Hotel @engcom-Bravo @engcom-Charlie