-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Remove code related to Microsoft IIS #39894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @ihor-sviziev. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes legacy code related to Microsoft IIS since the platform is no longer supported per system requirements.
- Removed IIS-specific header unsetting logic from app/bootstrap.php.
Comments suppressed due to low confidence (1)
app/bootstrap.php:50
- Consider updating related documentation or inline comments to clearly indicate that IIS-specific logic has been removed in line with current system requirements.
-if (empty($_SERVER['ENABLE_IIS_REWRITES']) || ($_SERVER['ENABLE_IIS_REWRITES'] != 1)) {
@magento create issue |
Functional tests failures are not related to changes in this pull request |
@magento run all tests |
@magento run all tests |
@ihor-sviziev Thank you for the contribution & collaboration! ✔️ QA PassedAs mentioned in the description & given in the System Requirement Documentation Microsoft windows & macOS are not supported. The code removal in the PR is related to the Microsoft IIS web server headers removal when the value of header "ENABLE_IIS_REWRITES" is not present. However that piece of code is not needed now as it is not supported. By looking at the documentation & code changes in the PR it is good to cleanup the code related to Microsoft IIS. Some of the tests are failing hence moving this PR to Extended Testing. |
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE |
@magento run Functional Tests B2B, Functional Tests CE |
@magento run Functional Tests B2B |
Description (*)
According to System requirements,
This means we can simply cleanup the code related to Microsoft IIS, which this Pull Request does.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: