Skip to content

Conversation

senthilengg
Copy link

Description (*)

  • Trigger CollectTotals only if the below condition are true
  • Quote is not virtual
  • Check GraphQl ResolverInfo OperationType is not "query"

Fixed Issues (if relevant)

  1. Fixes Cart Query >> CartPrice GraphQl Performance Optimisation #40209

Manual testing scenarios (*)

  1. Include CartPrice in Cart Graphql
  2. Also test all cart mutations

Questions or comments

  1. Similar GraphQl context check can be used in other areas to make the api's faster

Copy link

m2-assistant bot commented Oct 11, 2025

Hi @senthilengg. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ct-prd-pr-scan
Copy link

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com.

@senthilengg
Copy link
Author

@magento run Unit Tests

@senthilengg
Copy link
Author

@magento run Unit Tests

@senthilengg
Copy link
Author

@magento run Database Compare,Functional Tests CE,Functional Tests EE,Functional Tests B2B,Integration Tests,Magento Health Index,Sample Data Tests CE,Sample Data Tests EE,Sample Data Tests B2B,Static Tests,WebAPI Tests,Semantic Version Checker

@senthilengg
Copy link
Author

@magento run Static Tests

@senthilengg
Copy link
Author

@magento run WebAPI Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Project: Community Picked PRs upvoted by the community

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

Cart Query >> CartPrice GraphQl Performance Optimisation

3 participants