Add filename paramenter log #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundocapua
force-pushed
the
add_filename_paramenter_log
branch
3 times, most recently
from
eb77080 to
cceab50
Compare
facundocapua
force-pushed
the
add_filename_paramenter_log
branch
from
cceab50 to
67950c5
Compare
| * @return string | ||
| * @throws \InvalidArgumentException | ||
| */ | ||
| public function sanitizeFileName($fileName) |
There was a problem hiding this comment.
This should be private. Don't think child classes need to access that, let alone other objects.
There was a problem hiding this comment.
I agree with you... actually I prefer making methods protected, in case someone needs to overwrite the class but doesn't want to change the behaviour of this method.
I'm not sure how to make the proper test then, should those be integration test instead of unit tests? What do you think would be the proper approach?
Thanks!
There was a problem hiding this comment.
Why not just use reflection?
facundocapua
force-pushed
the
add_filename_paramenter_log
branch
from
2d830ec to
c364c4e
Compare
facundocapua
force-pushed
the
add_filename_paramenter_log
branch
from
c364c4e to
e1c7bd3
Compare
|
@fcapua-summa please sync with the develop branch and rerun travis builds. |
magento-team
pushed a commit
that referenced
this pull request
Jun 30, 2017
magento-team
pushed a commit
that referenced
this pull request
Jun 30, 2017
magento-engcom-team
pushed a commit
that referenced
this pull request
May 3, 2019
[pangolin] MQE-1536: Magento\Install\Test\TestCase\InstallTest is failing on php 7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening PR #2679