Commits on Jan 7, 2014

1. allow _resolveArguments to do sequential lookups …

   When resolving the arguments of PHP's internal classes, we cannot be
   sure about argument names. In many places of the PHP core, documentation
   differs from the implementation.
   
   A good example is the FilterIterator which triggered this bugreport:
   - The argument name is documented as $it:
   https://github.com/php/php-src/blob/PHP-5.6/ext/spl/internal/filteriterator.inc#L35
   - But it is implemented as $iterator:
   https://github.com/php/php-src/blob/PHP-5.6/ext/spl/spl_iterators.c#L2305
   
   This can cause problems with PHP runtimes (read: HHVM) that properly
   implement the documented specs. See the following HHVM issue for more
   information:
   facebook/hhvm#1492
   
   The attached patch keeps existing functionality working, but adds an
   additional fallback to sequentially based argument lookups. This is
   demonstrated in the change to Menu.php.

   

   danslo committed Jan 7, 2014
   Configuration menu

   • View commit details
   • Copy full SHA for a517275
   • Browse repository at this point

   Copy the full SHA

   a517275 View commit details

   Browse the repository at this point in the history