Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 5.5 support was removed #4669

Merged
merged 2 commits into from
Jun 12, 2016
Merged

Php 5.5 support was removed #4669

merged 2 commits into from
Jun 12, 2016

Conversation

fooman
Copy link
Contributor

@fooman fooman commented May 24, 2016

Removal of php 5.5 support should be reflected in the composer.json.

Removal of php 5.5 support should be reflected in the composer.json.
@mazhalai
Copy link
Contributor

@fooman unfortunately this is not the only composer.json

@vkublytskyi
Copy link

vkublytskyi commented May 24, 2016

@fooman Thanks for your commit. We will utilize it. As was pointed by @mazhalai there is another tasks that should be done for removal PHP 5.5 support. Internal ticket MAGETWO-53293 is created for processing this job.

@mazhalai
Copy link
Contributor

@vkublytskyi can you please post the internal ticket number?

@vkublytskyi
Copy link

Sure. MAGETWO-53293

@adragus-inviqa
Copy link
Contributor

Should this be "~5.6.0|7.0.2|^7.0.6"?

/cc #4615

@fooman
Copy link
Contributor Author

fooman commented May 24, 2016

@adragus-inviqa indeed - have updated the change

@mazhalai I am currently guessing you will need to change this internally as well for all the Enterprise modules so will not update the PR for now to cover the individual module composer.jsons. Unless you think it makes sense to do so.

@vkublytskyi vkublytskyi self-assigned this May 27, 2016
orlangur referenced this pull request May 27, 2016
TB for 2.1RC1 states PHP 5.5. is no longer supported, so it should be removed from the builds.
@orlangur
Copy link
Contributor

orlangur commented May 27, 2016

@vkublytskyi, please process #4175 together with this PR to have relevant information in all places.

@okorshenko okorshenko merged commit 85abcdd into magento:develop Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants