Escape Js Quote for layout updates #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchatard
force-pushed
the
widget_escape_js_quote
branch
from
d08659e to
f93a4d5
Compare
vkorotun
added
Area: Frontend
Progress: accept
bug report
Issue: Ready for Work
|
Internal ticket: MAGETWO-56552 |
vkorotun
added
Issue: Ready for Work
|
@mmansoorebay @vkorotun is this PR going to be included in 2.1.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Widget creation page (Content > Widgets), an error occurred if you have a
'in page name (for ex in french: "Page d'accueil CMS").The JS template for "layout update" is broken
FYI: this issue was in M1...